Fix popover crash on macOS Sequoia #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash where the popover would flash briefly but not display properly on macOS 15 (Sequoia), particularly on M4 Macs. Changes: - Replace deprecated MenuButton with modern Menu view - Use button action/target pattern instead of NSEvent.addLocalMonitorForEvents which can conflict with modern macOS event handling - Fix incorrect @ObservedObject usage in MainViewModel class (this property wrapper is only valid in SwiftUI Views) Tested on macOS 15 with M4 chip. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a crash where the popover would flash briefly but not display properly on macOS 15 (Sequoia), particularly on Apple Silicon Macs (tested on M4).
Changes
MenuButtonwith modernMenuview -MenuButtonwas deprecated in macOS 12 and can cause rendering issues on newer macOS versionsNSEvent.addLocalMonitorForEvents- Manual event monitoring can conflict with modern macOS event handling@ObservedObjectusage inMainViewModel- This property wrapper is only valid in SwiftUI Views, not regular classesTest plan
🤖 Generated with Claude Code