fix(query): fix fp for dynamic network_rules for Trusted Microsoft Services Not Enabled #7522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvices Not Enabled
github-actions
bot
added
community
cx-artur-ribeiro
requested changes
Jul 9, 2025
Contributor
cx-artur-ribeiro
left a comment
cx-artur-ribeiro
left a comment
There was a problem hiding this comment.
Hey Ricardo,
First of all, nice job tackling different available options for terraform azure instances!
Can you check my comments and see if you agree, please?
Thanks!
assets/queries/terraform/azure/trusted_microsoft_services_not_enabled/query.rego
Show resolved
Hide resolved
assets/queries/terraform/azure/trusted_microsoft_services_not_enabled/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/terraform/azure/trusted_microsoft_services_not_enabled/query.rego
Outdated
Show resolved
Hide resolved
…dynamic_network_rules
This extra test does not have the network_rules field
…dynamic_network_rules
cx-artur-ribeiro
requested changes
Jul 14, 2025
Contributor
cx-artur-ribeiro
left a comment
cx-artur-ribeiro
left a comment
There was a problem hiding this comment.
Hey Ricardo, take a look at my comments please.
...es/terraform/azure/trusted_microsoft_services_not_enabled/test/positive_expected_result.json
Outdated
Show resolved
Hide resolved
...es/terraform/azure/trusted_microsoft_services_not_enabled/test/positive_expected_result.json
Outdated
Show resolved
Hide resolved
assets/queries/terraform/azure/trusted_microsoft_services_not_enabled/query.rego
Outdated
Show resolved
Hide resolved
…dynamic_network_rules
…dynamic_network_rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Reason for Proposed Changes
Proposed Changes
not common_lib.valid_key(resource.dynamic, "network_rules").network_rules.bypassinsidedynamic.network_rules.content, mirroring the logic already applied to the static structure.azurerm_storage_account_network_rules, which is a separate resource.I submit this contribution under the Apache-2.0 license.