[CHIA-3606] Port create_offer_for_ids to @marshal
#20056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Quexington
force-pushed
the
quex.port_cat_spend_to_marshal
branch
from
dfceb28 to
151ce93
Compare
github-actions
bot
added
the
merge_conflict
Quexington
force-pushed
the
quex.port_create_offer_for_ids_to_marshal
branch
from
7366090 to
424b184
Compare
github-actions
bot
added
coverage-diff
and removed
merge_conflict
Quexington
force-pushed
the
quex.port_cat_spend_to_marshal
branch
from
4de29b4 to
08a885b
Compare
github-actions
bot
added
the
merge_conflict
Quexington
force-pushed
the
quex.port_create_offer_for_ids_to_marshal
branch
from
424b184 to
84adb91
Compare
github-actions
bot
removed
the
merge_conflict
geoffwalmsley
approved these changes
Oct 20, 2025
markelrod
approved these changes
Oct 21, 2025
|
Quexington
added
ready_to_merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR following #18593
There's some changes to the serialization of the pre-existing
_OfferEndpointResponsebecause we hadn't actually returned any of those responses yet, only used the classes as a vehicle to deserialize some free-form responses. The main thing is that I needed to a hack a way in streamable for using a specific serialization ofOfferthat was not the default dataclass serialization.