[CHIA-3608] Port take_offer to @marshal
#20061
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
…cations_to_streamable
Quexington
force-pushed
the
quex.port_get_offer_summary_to_marshal
branch
from
a1211c4 to
e5cb31b
Compare
Quexington
force-pushed
the
quex.port_take_offer_to_marshal
branch
from
76dd3e2 to
9c3ef2f
Compare
Quexington
force-pushed
the
quex.port_get_offer_summary_to_marshal
branch
from
1b5fda4 to
ec88d43
Compare
github-actions
bot
added
the
merge_conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR following #18593
Worth noting: I removed
"signing_responses"from the response of this RPC. It would also have the value ofNoneand is either a bad autofill or legacy property that I cannot fathom the purpose of at this juncture. Since it statically returned the same thing, I think it's impossible to miss. Can always be re-added in the future if the purpose is rediscovered.