fix: Improve navigate_page_history error messages #321
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check navigation result and provide specific feedback: - Detect when no previous/next page exists in history - Show timeout errors with duration details - Include actual error messages instead of generic text
mithun50
changed the title
|
Fixes: #259 |
OrKoN
reviewed
Oct 10, 2025
| result = await page.goForward(options); | ||
| } | ||
|
|
||
| // If result is null, navigation wasn't possible (no history) |
There was a problem hiding this comment.
I think this is not correct. Successful navigations could result in a null result if the navigation has no network request. We fixed Puppeteer in puppeteer/puppeteer#14160 to throw an error when there is no history. So the null result, should be treated as a successful navigation.
OrKoN
reviewed
Oct 10, 2025
| } | ||
| } catch { | ||
| response.appendResponseLine( | ||
| `Unable to navigate ${request.params.navigate} in currently selected page.`, |
There was a problem hiding this comment.
I think it would be sufficient to add the error.message to this message and revert other changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
navigate_page_historytool previously suppressed allnavigation errors with a generic message: "Unable to
navigate {back|forward} in currently selected page." This
provided no context about why the navigation failed, making
it difficult for users to understand whether:
Solution
Enhanced error handling to provide specific, actionable
feedback:
from
goBack()/goForward()to detect when navigation isimpossible
null, return:"Cannot navigate back, no previous page in history."
out after 30000ms."
generic text
Changes
navigate_page_historyhandler insrc/tools/pages.tsTesting
first page
end of history