fix: promoting moves are animated #221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonryoung02 is attempting to deploy a commit to the Ryan Gregory's projects Team on Vercel. A member of the Team first needs to authorize it. |
Clariity
reviewed
Nov 10, 2025
| return; | ||
| } | ||
|
|
||
| if (Object.keys(positionUpdates).length === 0) { |
Owner
There was a problem hiding this comment.
Suggested change
| if (Object.keys(positionUpdates).length === 0) { | |
| // this extra position check will only run if the position HAS changed, but we have been unable to identify the pieces that have moved, reducing the impact of the performance overhead | |
| if (Object.keys(positionUpdates).length === 0) { |
Clariity
reviewed
Nov 10, 2025
| chessColumnToColumnIndex(pawnSquare[0], noOfColumns, 'black') - | ||
| chessColumnToColumnIndex(promotionSquare[0], noOfColumns, 'black'), | ||
| ); | ||
| if (columnDifference > 1 || oldPiece[0] !== newPiece[0]) { |
Owner
There was a problem hiding this comment.
Suggested change
| if (columnDifference > 1 || oldPiece[0] !== newPiece[0]) { | |
| // ensure piece has moved at most 1 column away and is the same colour | |
| if (columnDifference > 1 || oldPiece[0] !== newPiece[0]) { |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added
utils.getPromotionUpdatesandutils.pawnPromotesAtSquaresto identify promoting moves.In the animation useEffect I added a condition where the promotion is animated only if
positionUpdatesdoesn't have any pieces to animate andpromotionUpdateshas one piece to animate. I added these constraints to simplify the problem, because the main benefit of the fix is to animate when only the promotion move is being played or undone. In other cases it can be hard to verify if the promotion actually happened or how you should handle conflicts withpositionUpdates.Fixes #220
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
I didn't write any unit tests for my logic because I didn't see a test suite to add them to. Let me know if I'm misunderstanding storybook!
Checklist:
Screenshots (if appropriate):
Additional context
Add any other context about the pull request here.