Skip to content

refactor:changed some section of code to follow DRY principle #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor:changed some section of code to follow DRY principle #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 33 additions & 41 deletions app/(components)/EditTicketForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,23 @@
"use client";
import { useRouter } from "next/navigation";
import React, { useState } from "react";
'use client';
import { useRouter } from 'next/navigation';
import React, { useState } from 'react';

const EditTicketForm = ({ ticket }) => {
const EDITMODE = ticket._id === "new" ? false : true;
const EDITMODE = ticket._id === 'new' ? false : true;
const router = useRouter();
const startingTicketData = {
title: "",
description: "",
title: '',
description: '',
priority: 1,
progress: 0,
status: "not started",
category: "Hardware Problem",
status: 'not started',
category: 'Hardware Problem',
};

if (EDITMODE) {
startingTicketData["title"] = ticket.title;
startingTicketData["description"] = ticket.description;
startingTicketData["priority"] = ticket.priority;
startingTicketData["progress"] = ticket.progress;
startingTicketData["status"] = ticket.status;
startingTicketData["category"] = ticket.category;
for (let i in startingTicketData) {
startingTicketData[i] = ticket[i];
}
}

const [formData, setFormData] = useState(startingTicketData);
Expand All @@ -38,38 +35,33 @@ const EditTicketForm = ({ ticket }) => {
const handleSubmit = async (e) => {
e.preventDefault();

let url = '/api/Tickets';
let method = 'POST';
if (EDITMODE) {
const res = await fetch(`/api/Tickets/${ticket._id}`, {
method: "PUT",
headers: {
"Content-type": "application/json",
},
body: JSON.stringify({ formData }),
});
if (!res.ok) {
throw new Error("Failed to update ticket");
}
} else {
const res = await fetch("/api/Tickets", {
method: "POST",
body: JSON.stringify({ formData }),
//@ts-ignore
"Content-Type": "application/json",
});
if (!res.ok) {
throw new Error("Failed to create ticket");
}
url += '/' + ticket._id;
method = 'PUT';
}

const res = await fetch(url, {
method: method,
headers: {
'Content-type': 'application/json',
},
body: JSON.stringify({ formData }),
});
if (!res.ok) {
throw new Error('Failed to update ticket');
}

router.refresh();
router.push("/");
router.push('/');
};

const categories = [
"Hardware Problem",
"Software Problem",
"Application Deveopment",
"Project",
'Hardware Problem',
'Software Problem',
'Application Deveopment',
'Project',
];

return (
Expand All @@ -79,7 +71,7 @@ const EditTicketForm = ({ ticket }) => {
method="post"
className="flex flex-col gap-3 w-1/2"
>
<h3>{EDITMODE ? "Update Your Ticket" : "Create New Ticket"}</h3>
<h3>{EDITMODE ? 'Update Your Ticket' : 'Create New Ticket'}</h3>
<label>Title</label>
<input
id="title"
Expand Down Expand Up @@ -178,7 +170,7 @@ const EditTicketForm = ({ ticket }) => {
<input
type="submit"
className="btn max-w-xs"
value={EDITMODE ? "Update Ticket" : "Create Ticket"}
value={EDITMODE ? 'Update Ticket' : 'Create Ticket'}
/>
</form>
</div>
Expand Down