Skip to content

Conversation

kafka1991
Copy link
Contributor

@kafka1991 kafka1991 commented Aug 27, 2025

Summary

Update docs for chdb

Checklist

@kafka1991 kafka1991 requested a review from a team as a code owner August 27, 2025 08:20
@kafka1991 kafka1991 self-assigned this Aug 27, 2025
@kafka1991 kafka1991 requested a review from auxten August 27, 2025 08:20
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clickhouse-docs Ready Ready Preview Aug 31, 2025 5:51am
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
clickhouse-docs-jp Ignored Ignored Aug 31, 2025 5:51am
clickhouse-docs-ru Ignored Ignored Preview Aug 31, 2025 5:51am
clickhouse-docs-zh Ignored Ignored Preview Aug 31, 2025 5:51am

@kafka1991
Copy link
Contributor Author

@auxten @wudidapaopao
Please take a review when you have time, thanks!

Copy link
Member

@Blargian Blargian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from two small formatting requests:

  1. Using Image component for consistent images in the docs
  2. Using sentence casing for headers for consistency across all pages

Comment on lines 61 to 63
<div align="center">
<img src="https://github.com/chdb-io/chdb/raw/main/docs/_static/df_bench.png" width="600" alt="DataFrame Benchmark Results" />
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kafka1991,
Images can be placed at https://github.com/ClickHouse/clickhouse-docs/tree/main/static/images/chdb/

It's then possible to import in the markdown file:

import Image from '@theme/IdealImage';
import image_name from '@site/static/images/chdb/hyperdx_cloud.png';

You can use the Image component like this:

<Image src={image_name} size="md"/>

See https://github.com/ClickHouse/clickhouse-docs/blob/main/contribute/style-guide.md#images


## GitHub repository {#github-repository}
### Standalone Queries {#standalone-queries}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Standalone Queries {#standalone-queries}
### Standalone queries {#standalone-queries}

```

## Build from source {#build-from-source}
## Error Handling {#error-handling}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Error Handling {#error-handling}
## Error handling {#error-handling}

```

## GitHub Repository {#github-repository}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## GitHub Repository {#github-repository}
## GitHub repository {#github-repository}

```

Python file example:
### Basic Python Usage {#basic-python-usage}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Basic Python Usage {#basic-python-usage}
### Basic Python usage {#basic-python-usage}

### Query(query, *format) (ephemeral) {#queryquery-format-ephemeral}
chDB-bun supports two query modes: ephemeral queries for one-time operations and persistent sessions for maintaining database state.

### Ephemeral Queries {#ephemeral-queries}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Ephemeral Queries {#ephemeral-queries}
### Ephemeral queries {#ephemeral-queries}


```bash
curl -sL https://lib.chdb.io | bash
```

## Install {#install}
#### Install Build Tools {#install-build-tools}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Install Build Tools {#install-build-tools}
#### Install build tools {#install-build-tools}

Install [libchdb](https://github.com/chdb-io/chdb):
## Installation {#installation}

### Step 1: Install System Dependencies {#install-system-dependencies}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Step 1: Install System Dependencies {#install-system-dependencies}
### Step 1: install system dependencies {#install-system-dependencies}

@@ -51,12 +50,25 @@ You can listen to a brief project introduction to chDB, courtesy of Alexey Milov
<iframe width="560" height="315" src="https://www.youtube.com/embed/cuf_hYn7dqU?si=SzUm7RW4Ae5-YwFo" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>
</div>

## Performance Benchmarks {#performance-benchmarks}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Performance Benchmarks {#performance-benchmarks}
## Performance benchmarks {#performance-benchmarks}

@@ -11,6 +11,14 @@ keywords: ['chdb', 'embedded', 'clickhouse-lite', 'in-process', 'in process']
chDB is a fast in-process SQL OLAP Engine powered by [ClickHouse](https://github.com/clickhouse/clickhouse).
You can use it when you want to get the power of ClickHouse in a programming language without needing to connect to a ClickHouse server.

## Key Features {#key-features}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Key Features {#key-features}
## Key features {#key-features}

@kafka1991
Copy link
Contributor Author

LGTM apart from two small formatting requests:

  1. Using Image component for consistent images in the docs
  2. Using sentence casing for headers for consistency across all pages

Fixed.

@kafka1991
Copy link
Contributor Author

@Blargian Thanks for the review!

@auxten
Copy link
Member

auxten commented Sep 1, 2025

LGTM

@auxten auxten merged commit f0e42d4 into main Sep 1, 2025
15 checks passed
@kafka1991 kafka1991 deleted the victor_chdb_doc branch September 1, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants