-
Notifications
You must be signed in to change notification settings - Fork 374
Glossary: modifications to glossary system #4344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…re already wrapped, only do concepts pages (and quick-starts) and only run the processor for specific paths (core concepts, quick starts for now)
@Blargian is attempting to deploy a commit to the ClickHouse Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
return filePath?.includes(allowedPath); | ||
}); | ||
|
||
return (filePath?.endsWith('.mdx') || filePath?.endsWith('.md')) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhtclk correct me if i'm wrong but I don't see why this won't work on .md files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on build time, the plugin would look for "^^ ^^" but it would only work properly on mdx files because it's injecting our custom react components, which aren't parsed properly by md files because they can't parse JSX, only standard markdown syntax.
const allowedPaths = [ | ||
'docs/concepts/*', | ||
'docs/managing-data/core-concepts/*', | ||
'docs/getting-started/*' | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to be processing all the files when only a small portion have ^^ ^^
so let's just do a subset. We can add as we go along.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll just have to adjust the glossary-transformer so that it only processes mdx files.
UPDATE: nevermind I was wrong :D
Oh ye of little faith :-) I pushed a commit to rename
https://clickhouse-docs-f4wde8985-clickhouse.vercel.app/docs/parts#part-merges |
Summary
Some small improvements:
.md
or.mdx
## What are parts
should not become## What are ^^Parts^^
wrap-glossary-terms.py
on^^ ^^
from some parts of the docs which don't need to be wrapped (Let's begin with core-concepts, quick-starts), we can expand in future.Future improvements:
could just be
We'll need to add a preprocessing step to remove
^^ ^^
before translating, or figure out a way to make this multilingual.Checklist