Add disable private sub #4627
Open
Add disable private sub #4627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4627 +/- ##
==========================================
- Coverage 72.93% 69.24% -3.70%
==========================================
Files 83 21 -62
Lines 5368 3638 -1730
==========================================
- Hits 3915 2519 -1396
+ Misses 1453 1119 -334
... and 64 files with indirect coverage changes
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…o add_disable_private_sub
RishabhJain2018
requested changes
May 2, 2025
| <td>{{key.submitted_at | date:'medium'}}</td> | ||
|
|
||
| <td ng-if="challenge.currentPhaseLeaderboardPublic" class="center"> | ||
| <td ng-if="!challenge.disable_private_submission && challenge.currentPhaseLeaderboardPublic" class="center"> |
| !challenge.isStaticCodeUploadChallenge" data-field="file">Environment Logs</th> | ||
| <th class="align-center fs-18 w-300" data-field="file">Submitted at</th> | ||
| <th class="align-center fs-18 w-300" ng-if="challenge.currentPhaseLeaderboardPublic" | ||
| <th class="align-center fs-18 w-300" ng-if="!challenge.disable_private_submission && challenge.currentPhaseLeaderboardPublic" |
There was a problem hiding this comment.
Why do we need this check in my-submissions page? My submissions should ideally display all the submissions for a user.
…o add_disable_private_sub
…o add_disable_private_sub
…o add_disable_private_sub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.