Skip to content

Fix #4614: Resolve profile update failure when modifying First Name, Last Name, or Affiliation fields. #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix #4614: Resolve profile update failure when modifying First Name, Last Name, or Affiliation fields. #4629

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7c397dd
Fix: Resolved profile update failure when modifying First Name, Last …
Amarta113 Apr 30, 2025
7c16b9e
Merge branch 'master' of https://github.com/Amarta113/EvalAI
Amarta113 Apr 30, 2025
2c4bd80
Merge branch 'master' into master
RishabhJain2018 May 2, 2025
19cfcc7
Merge branch 'Cloud-CV:master' into master
Amarta113 May 6, 2025
a2da28b
Merge branch 'Cloud-CV:master' into master
Amarta113 May 8, 2025
ac66593
Merge branch 'Cloud-CV:master' into master
Amarta113 Jul 9, 2025
7457ae2
Merge branch 'Cloud-CV:master' into master
Amarta113 Jul 16, 2025
da35d4e
Merge branch 'Cloud-CV:master' into master
Amarta113 Jul 19, 2025
cf47872
Merge branch 'Cloud-CV:master' into master
Amarta113 Jul 28, 2025
177375c
Merge branch 'Cloud-CV:master' into master
Amarta113 Aug 6, 2025
74df87b
Merge branch 'Cloud-CV:master' into master
Amarta113 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions frontend/src/js/controllers/profileCtrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
vm.status = 'Show';
vm.token = '';
vm.expiresAt = '';
const urlFields = ["github_url", "google_scholar_url", "linkedin_url"];

// default parameters
$rootScope.canShowOldPassword = false;
Expand Down Expand Up @@ -227,10 +228,12 @@
vm.user.google_scholar_url = vm.user.google_scholar_url === null ? "" : vm.user.google_scholar_url;
vm.user.linkedin_url = vm.user.linkedin_url === null ? "" : vm.user.linkedin_url;

if (!vm.isURLValid(vm.user[editid])) {
vm.isFormError = true;
$rootScope.notify("error", "URL length should not be greater than 200 or is in invalid format!");
return;
if(urlFields.includes(editid)){
if (!vm.isURLValid(vm.user[editid])) {
vm.isFormError = true;
$rootScope.notify("error", "URL must be valid and should not exceed 200 characters.");
return;
}
}

var parameters = {};
Expand Down