feat: move smart configs into their own files #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to redo the service / task property handling at some point. This is a pain in the ass if the smart config stays inside the task properties. Furthermore it simply does not make sense to keep it there anymore as smart is mostly used on single tasks and not on all of them, just creating clutter and overhead.
Modification
Moved each smart config into a separate file in the modules/CloudNet-Smart directory, if the config was enabled. Disabled configs are not migrated. Old configs are removed from the task props.
Result
Smart configs are not part of the task props anymore and the property rework can be done.