-
Notifications
You must be signed in to change notification settings - Fork 2
210 refactor chat 기능 리팩토링 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
X1n9fU
wants to merge
16
commits into
develop
Choose a base branch
from
210-refactor-chat-기능-리팩토링
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
The head ref may contain hidden characters: "210-refactor-chat-\uAE30\uB2A5-\uB9AC\uD329\uD1A0\uB9C1"
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doma17
reviewed
Jul 1, 2025
Contributor
doma17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 검토를 추가하겠습니다.
src/main/java/inu/codin/codin/common/security/util/SecurityUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/inu/codin/codin/common/security/util/SecurityUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/inu/codin/codin/domain/chat/stomp/StompMessageService.java
Show resolved
Hide resolved
src/main/java/inu/codin/codin/domain/chat/controller/ChattingController.java
Outdated
Show resolved
Hide resolved
Merged
gisu1102
reviewed
Jul 2, 2025
src/main/java/inu/codin/codin/domain/chat/domain/chatroom/ParticipantInfo.java
Outdated
Show resolved
Hide resolved
gisu1102
reviewed
Jul 2, 2025
src/main/java/inu/codin/codin/domain/chat/domain/chatroom/ParticipantInfo.java
Show resolved
Hide resolved
gisu1102
reviewed
Jul 2, 2025
src/main/java/inu/codin/codin/domain/chat/domain/chatroom/Participants.java
Show resolved
Hide resolved
gisu1102
reviewed
Jul 2, 2025
src/main/java/inu/codin/codin/domain/chat/domain/chatroom/Participants.java
Show resolved
Hide resolved
gisu1102
reviewed
Jul 2, 2025
src/main/java/inu/codin/codin/domain/chat/event/ChatRoomEventListener.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
chatroom, chatting으로 나눠진 패키지를 controller, domain, repository, service 내부에서 동일한 깊이에 위치하도록 설정
변경 전
변경 후
-> Participants 에서 ParticipantsInfo로 접근하도록 캡슐화 진행
( 이미 존재하는 채팅방이 있을 시에 해당 채팅방으로 리다이렉트, 303 에러로 변경)
스크린샷 (선택)
💬 리뷰 요구사항(선택)