Skip to content
This repository was archived by the owner on Jun 7, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions app/services/llm_response_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def _get_context(self, question: str) -> Union[str, list[str]]:
return output
except ValueError as ve:
raise HTTPException(
status_code=500, detail=f"Error getting context: {str(ve)}"
status_code=404, detail=f"Error getting context: {str(ve)}"
)
except Exception as e:
logger.error(f"Unexpected error in _get_context for question '{question}': {str(e)}", exc_info=True)
Expand All @@ -59,26 +59,31 @@ def _get_context(self, question: str) -> Union[str, list[str]]:
)

def generate_llm_response(self, question: schemas.Question) -> StreamingResponse:
context = self._get_context(question.question)
try:
context = self._get_context(question.question)
except HTTPException as e:
logger.error(f"No context found", exc_info=True)
context = ""

formatted_messages = ""
context_messages = ""
# context_messages = ""

if question.messages:
formatted_messages = "\n".join(
[f"{msg.sender}: {msg.content}" for msg in question.messages]
)
context_messages = self._get_context(formatted_messages)
# context_messages = self._get_context(formatted_messages)

messages = [
SystemMessage(self._CHATBOT_INSTRUCTIONS),
SystemMessage(f"Conversazione precedente: {formatted_messages}"),
SystemMessage(
f"Contesto: {context}\n{context_messages}",
f"Contesto: {context}",
),
SystemMessage(f"Conversazione precedente: {formatted_messages}"),
HumanMessage(f"Domanda a cui devi rispondere: {question}"),
]
print()
print(f"PROMPT: {context} {context_messages}")
print(f"PROMPT: {context}")
print()
try:
stream_response = self._LLM._model.astream(messages)
Expand Down
4 changes: 2 additions & 2 deletions tests/services/test_llm_response_services.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ def test_llm_response_service_get_context_false(monkeypatch):
with pytest.raises(HTTPException) as excinfo:
llm_response_service._get_context(question)
assert (
excinfo.value.status_code == 500
), "Should raise HTTPException with status code 500"
excinfo.value.status_code == 404
), "Should raise HTTPException with status code 404"
assert str(excinfo.value.detail).startswith(
"Error getting context:"
), "Should raise HTTPException with the correct error message"
Expand Down