Fix empty result set handling for D1 queries (Issue #4) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4 - Fix cursor to properly handle empty result sets from D1 API - Refactor connection.py with DRY principle (BaseCursorMixin, helper functions) - Add MARK sectioning throughout codebase for better navigation - Create shared test utilities (tests/test_utils.py) and fixtures in conftest.py - Add missing Worker integration tests for parity with REST API tests - Add new Worker endpoints: sqli-orm, sqli-like, sqlalchemy-upsert, etc. - Update README with async engine, Python Workers, pandas, JSON filtering docs - Add SQLAlchemy and D1 logos to README header - Fix Makefile integration_tests target to run tests/integration/ directly - Improve workerd cleanup in test fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4