Skip to content

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Aug 31, 2025

Specifies v18+ for building, v24 for dev server.

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner August 31, 2025 04:49
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 31, 2025
Copy link

github-actions bot commented Aug 31, 2025

🎨 Storybook Build Status

Build failed!

⏰ Completed at: 08/31/2025, 04:50:11 AM UTC

🔗 Links


⚠️ Please check the workflow logs for error details.

Copy link

github-actions bot commented Aug 31, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 08/31/2025, 05:13:45 AM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

@DrJKL
Copy link
Contributor

DrJKL commented Sep 1, 2025

Are you sure you can get away with 18 for the build?
I think we should just set the minimum to be 24 generally.

@webfiltered
Copy link
Contributor Author

If by, "are you sure", you mean, "did I test it?".. then yes. Yes, I did. I wasn't expecting v18 to work - gut instinct was v20. Close!

Was initially thinking of changing to v24 for simplicity, but decided to keep current format as it's truthful. Build tooling is usually very far inland, compared to the bleeding edge of dev tooling.

@webfiltered webfiltered merged commit b592c90 into main Sep 1, 2025
14 checks passed
@webfiltered webfiltered deleted the nodejs-readme branch September 1, 2025 18:36
@benceruleanlu benceruleanlu mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants