allow copy and paste when using minimap or canvas menu (bottom right) #6055

christian-byrne · 2025-10-14T19:04:52Z

Summary

Fixed intermittent copy/paste failures when clicking minimap or canvas control buttons by expanding target whitelist in document-level clipboard handlers.

Changes

What: Expanded isTargetInGraph check in useCopy.ts and usePaste.ts to include minimap and canvas controls
Added IDs:
- comfy-minimap on minimap container (src/renderer/extensions/minimap/MiniMap.vue)
- graph-canvas-controls on canvas controls ButtonGroup (src/components/graph/GraphCanvasMenu.vue)
Test Infrastructure: Created Minimap test fixture following existing pattern (Topbar, SidebarTab)

Technical Details

Document-level clipboard handlers (added Feb 2025) replace LiteGraph's canvas-only handlers but require event target to be within graph workspace. Previous implementation only checked:

e.target.id === 'graph-canvas' ||
e.target.classList.contains('litegraph') ||
e.target.classList.contains('graph-canvas-container')

Clicking UI elements (minimap buttons, zoom controls) caused focus loss, making target check fail silently.

┆Issue is synchronized with this Notion page by Unito

github-actions · 2025-10-14T19:05:20Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 10/18/2025, 07:29:03 PM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

github-actions · 2025-10-14T19:05:43Z

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 10/18/2025, 07:43:41 PM UTC

📈 Summary

Total Tests: 499
Passed: 465 ✅
Failed: 1 ❌
Flaky: 2 ⚠️
Skipped: 31 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 456 / ❌ 1 / ⚠️ 2 / ⏭️ 31
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

src/composables/usePaste.ts

…s review feedback Co-authored-by: Myestery <[email protected]>

AustinMroz · 2025-10-17T17:00:15Z

I've been exploring similar options over in #6087.

Thoughts on broadening the target restrictions to e.target instanceof HTMLTextAreaElement || e.target instanceof HTMLInputElement? IIRC the only reason we don't grab every clipboard event was that supporting undo/redo for text inputs was non-feasible. Are there any cases other than text inputs where we don't want our copy/paste handler to apply?

Edit to clarify: The changes here are an improvement and LGTM, even if further changes will be made down the line.

benceruleanlu · 2025-10-17T17:43:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/composables/useCopy.ts

benceruleanlu

LGTM, any ideas on a more robust solution that won't need id upkeep to prevent drifting?

christian-byrne · 2025-10-17T21:36:54Z

LGTM, any ideas on a more robust solution that won't need id upkeep to prevent drifting?

Nothing comes to mind. Is ID drifting common? Would be pretty bad to change IDs and not audit all usage first.

Thankfully since I added tests, we will be able to spot that case immediately when the test fails.

github-actions · 2025-10-18T19:29:34Z

Bundle Size Report

App Entry Points

Main application bundles

File	Size	Gzip	Brotli
assets/index-Cu3g1N6G.js	2.02 MB	381 kB	296 kB
~~assets/index-CuLZTtAC.js~~
assets/index-CXG_5Ix6.js	9.67 MB	1.99 MB	1.43 MB
~~assets/index-E0kYOj1H.js~~
assets/index-PESgPnbc.js	507 B	292 B	249 B

Category Total: 11.7 MB

Core Views

Major application views and screens

File	Size	Gzip	Brotli
~~assets/GraphView-BLQk4ujW.js~~
assets/GraphView-BsMVw2gy.js	714 kB	139 kB	108 kB
assets/UserSelectView-DIVk3Vdr.js	7.99 kB	2.4 kB	2.1 kB
~~assets/UserSelectView-Kp6GcnoT.js~~

Category Total: 722 kB

UI Panels

Settings and configuration panels

File	Size	Gzip	Brotli
~~assets/AboutPanel-Bq9ApgWv.js~~
assets/AboutPanel-gCsLk9Xp.js	10.1 kB	2.58 kB	2.27 kB
~~assets/CreditsPanel-CVBAywTM.js~~
assets/CreditsPanel-DtXLBHdt.js	21.9 kB	5.21 kB	4.54 kB
~~assets/ExtensionPanel-DFmOwtDV.js~~
assets/ExtensionPanel-gR_9LHV7.js	11.9 kB	2.75 kB	2.4 kB
assets/KeybindingPanel-CYjSSRkS.js	15.1 kB	3.68 kB	3.24 kB
~~assets/KeybindingPanel-IQI7hKov.js~~
assets/ServerConfigPanel-BJ7OL5nI.js	8.04 kB	2.09 kB	1.83 kB
~~assets/ServerConfigPanel-D2PD5OIf.js~~
assets/UserPanel-BFDcG5jS.js	7.76 kB	1.98 kB	1.72 kB
~~assets/UserPanel-D0nz-wnp.js~~

Category Total: 74.8 kB

Services

Business logic and services

File	Size	Gzip	Brotli
~~assets/keybindingService-Cnd76Vc_.js~~
assets/keybindingService-Q8YZIFQi.js	7.22 kB	1.75 kB	1.5 kB
~~assets/serverConfigStore-CB-AA3JS.js~~
assets/serverConfigStore-D8Rx83Cp.js	2.79 kB	890 B	783 B

Category Total: 10 kB

Utilities

Helper functions and utilities

File	Size	Gzip	Brotli
assets/mathUtil-CTARWQ-l.js	1.07 kB	525 B	452 B

Category Total: 1.07 kB

Other

Uncategorized bundles

File	Size	Gzip	Brotli
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js	1.12 kB	577 B	494 B

Category Total: 1.12 kB

Overall Total Size: 12.5 MB
Total Bundle Count: 15

christian-byrne assigned jtydhr88 and Myestery Oct 14, 2025

christian-byrne requested a review from jtydhr88 as a code owner October 14, 2025 19:04

christian-byrne added area:navigation area:hotkeys area:minimap labels Oct 14, 2025

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 14, 2025

Myestery reviewed Oct 14, 2025

View reviewed changes

src/composables/usePaste.ts Outdated Show resolved Hide resolved

christian-byrne mentioned this pull request Oct 14, 2025

Support pasting nodes when switching workflow tabs; currently, you need one more click to activate the canvas #5844

Open

christian-byrne added the claude-review Add to trigger a PR code review from Claude Code label Oct 17, 2025

christian-byrne and others added 2 commits October 17, 2025 01:22

allow copy and paste when minimap target

4d012f5

[refactor] extract clipboard target check to shared helper - addresse…

12bdf89

…s review feedback Co-authored-by: Myestery <[email protected]>

christian-byrne requested review from a team, KarryCharon, Yorha4D, arjansingh, comfyui-wiki, ltdrdata, pythongosssss, shinshin86, viva-jinyi and webfiltered as code owners October 17, 2025 08:51

christian-byrne force-pushed the allow-copy-paste-on-minimap branch from a059806 to 12bdf89 Compare October 17, 2025 09:02

christian-byrne removed the claude-review Add to trigger a PR code review from Claude Code label Oct 17, 2025

chatgpt-codex-connector bot reviewed Oct 17, 2025

View reviewed changes

src/composables/useCopy.ts Show resolved Hide resolved

benceruleanlu previously approved these changes Oct 17, 2025

View reviewed changes

Merge branch 'main' into allow-copy-paste-on-minimap

633011e

christian-byrne dismissed benceruleanlu’s stale review via 633011e October 18, 2025 19:27

AustinMroz mentioned this pull request Oct 18, 2025

Support cross domain/application copy/paste #6087

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

allow copy and paste when using minimap or canvas menu (bottom right) #6055

allow copy and paste when using minimap or canvas menu (bottom right) #6055

Uh oh!

christian-byrne commented Oct 14, 2025 •

edited by sync-by-unito bot

Loading

Uh oh!

github-actions bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

AustinMroz commented Oct 17, 2025 •

edited

Loading

Uh oh!

benceruleanlu commented Oct 17, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

benceruleanlu left a comment

Uh oh!

christian-byrne commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

allow copy and paste when using minimap or canvas menu (bottom right) #6055

Are you sure you want to change the base?

allow copy and paste when using minimap or canvas menu (bottom right) #6055

Uh oh!

Conversation

christian-byrne commented Oct 14, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Technical Details

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

Uh oh!

AustinMroz commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benceruleanlu commented Oct 17, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

benceruleanlu left a comment

Choose a reason for hiding this comment

Uh oh!

christian-byrne commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 18, 2025

Bundle Size Report

App Entry Points

Core Views

UI Panels

Services

Utilities

Other

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

christian-byrne commented Oct 14, 2025 •

edited by sync-by-unito bot

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

AustinMroz commented Oct 17, 2025 •

edited

Loading