Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 17, 2025

Summary

Implemented error recovery system to handle Firebase auth/requires-recent-login errors when deleting accounts or updating passwords.

2025-10-17.01-35-47_processed_20251017_013635.mp4

Changes

  • What: Added ErrorRecoveryStrategy pattern to useErrorHandling composable with automatic retry logic for sensitive Firebase operations
  • Breaking: None - recovery strategies are optional, all existing code unchanged

Technical Details

Firebase enforces reauthentication for security-sensitive operations (account deletion, password changes) after ~5 minutes of inactivity. Previously these operations failed with cryptic error messages.

New flow:

  1. Operation throws auth/requires-recent-login
  2. Recovery strategy shows confirmation dialog
  3. User logs out and re-authenticates
  4. Operation automatically retries

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 17, 2025
Copy link

github-actions bot commented Oct 17, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/17/2025, 08:44:26 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

Copy link

github-actions bot commented Oct 17, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/17/2025, 08:59:45 AM UTC

📈 Summary

  • Total Tests: 499
  • Passed: 467 ✅
  • Failed: 1 ❌
  • Flaky: 1 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 458 / ❌ 1 / ⚠️ 1 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@benceruleanlu
Copy link
Member

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Member

@benceruleanlu benceruleanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ErrorRecoveryStrategy pipeline being super extensible is really cool to see

@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.29 labels Oct 18, 2025
@christian-byrne christian-byrne merged commit 10748bd into main Oct 18, 2025
39 of 40 checks passed
@christian-byrne christian-byrne deleted the auth/fix-delete-new-access-token branch October 18, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.29 area:auth needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants