fix: Only publish to Chromatic on push to main branch #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates localization files to add new translation keys for node version management features and modifies the Chromatic workflow to optimize build usage by only publishing to Chromatic on main branch pushes.
- Added new translation keys for bulk update functionality and version compatibility features across all supported languages
- Modified Chromatic workflow to conditionally publish only on main branch pushes
- Disabled PR commenting since Chromatic builds no longer run for PRs
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| locales/*/common.json | Added translations for new node version management features |
| .github/workflows/chromatic.yml | Modified to only publish to Chromatic on main branch pushes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Skip Chromatic publish step in PRs to reduce unnecessary builds - Only run Chromatic deployment when pushing to main branch - Keep Storybook build for all branches for validation - Disable PR commenting since we're not publishing on PRs This change reduces Chromatic usage and focuses visual testing on main branch changes only. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
snomiao
force-pushed
the
sno-reduce-chromatic
branch
from
95c6355 to
2cbda14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
if: github.event_name == 'push' && github.ref == 'refs/heads/main'to the Chromatic publish stepBenefits
🤖 Generated with Claude Code