Run CI when merging to dev/* branches #504
Conversation
| on: | ||
| # Triggers the workflow on push or pull request events but only for the main or release branches | ||
| push: | ||
| branches: [ main, 'rel/*' ] |
There was a problem hiding this comment.
| branches: [ main, 'rel/*' ] | |
| branches: [ main, 'dev/*', 'rel/*' ] |
I think we need it here too, but not 100% sure. that would also let us push things in 'development' to our feeds and such, but not sure if that'll have other ramifications to which feeds and that is, but probably fine for now?
There was a problem hiding this comment.
on: push
This section is described in the filters docs here:
the push event has a branches filter that causes your workflow to run only when a push to a branch that matches the branches filter occurs, instead of when any push occurs.
on:
push:
branches:
on: pull_request
This is described by workflow syntax docs here:
When using the
pull_requestandpull_request_targetevents, you can configure a workflow to run only for pull requests that target specific branches.
on:
pull_request:
branches:
It seems like we only need to specify the branch in pull_request, but we won't know for sure until we've merged this PR and rechecked in #500.
There was a problem hiding this comment.
No dice in #500, let's try doing both then.
2 participants
Needed for #500