Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Oct 29, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 29, 2025 04:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures the Gradle plugin build with explicit Kotlin compiler options and Gradle API version requirements. The changes standardize the build configuration to target JDK 17 and Kotlin 2.2, while declaring compatibility with Gradle API 9.0.0.

Key changes:

  • Adds Kotlin compiler options including API/language version 2.2, JVM target 17, and warning-as-error enforcement
  • Declares Gradle Plugin API version 9.0.0 for the plugin's published metadata
  • Configures Java compilation to use JDK 17 release flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

This comment was marked as outdated.

@Goooler Goooler force-pushed the g/20251029/kotlin-lang-version branch from bbe5265 to 495784b Compare October 29, 2025 04:21
@Goooler Goooler force-pushed the g/20251029/kotlin-lang-version branch from 495784b to c74152c Compare October 29, 2025 04:24

kotlin {
compilerOptions {
jvmTarget = JvmTarget.JVM_21
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback to the default, Java 17. Seems no need to require it running on Java 21.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check after the merge; I remember it was needed

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
build.gradle.kts (1)

5-7: Remove unused import JvmDefaultMode.

The import at line 5 is not referenced in this file.

-import org.jetbrains.kotlin.gradle.dsl.JvmDefaultMode
 import org.jetbrains.kotlin.gradle.dsl.JvmTarget
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbe5265 and c74152c.

📒 Files selected for processing (4)
  • build.gradle.kts (2 hunks)
  • gradle/libs.versions.toml (1 hunks)
  • tools/cli/build.gradle.kts (0 hunks)
  • tools/gradle-plugin/build.gradle.kts (3 hunks)
💤 Files with no reviewable changes (1)
  • tools/cli/build.gradle.kts
🚧 Files skipped from review as they are similar to previous changes (2)
  • tools/gradle-plugin/build.gradle.kts
  • gradle/libs.versions.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build (ubuntu-latest)
🔇 Additional comments (2)
build.gradle.kts (2)

80-85: Approve centralized Kotlin compiler configuration.

The KotlinCompile task configuration cleanly centralizes language and release targets across all projects. The combination of jvmTarget and -Xjdk-release ensures consistent bytecode generation and cross-compilation compatibility.


76-85: API contract verified—no issues found.

The centralized configuration is correct. JvmTarget.fromTarget() is a public Kotlin API that accepts string parameters, and libs.versions.jdkRelease.get() returns "17", which is a fully supported target version. The call at line 82 follows the documented API usage pattern and will produce the expected enum value JvmTarget.JVM_17.

The subproject override in tools/idea-plugin/build.gradle.kts (hardcoded to JvmTarget.JVM_21) is intentional and documented with a comment explaining the IDEA 2024.2+ requirement.

@egorikftp egorikftp merged commit 91e9a2a into main Oct 29, 2025
3 checks passed
@egorikftp egorikftp deleted the g/20251029/kotlin-lang-version branch October 29, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants