Added python 3 support and updated dependencies #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @maxmalysh , thanks for this PR. I should have it tested, merged, and released this weekend. If I remember correctly, the main thing that was holding back Python3 support was the
I'm also thinking of unpinning the version of |
|
Can we merge this? |
This was referenced May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've added Python 3 support by using
basestringfromfuturepackage (the corresponding import ispast.builtins), now it works both in Python 2 and 3.Also I've updated
ethereumandrequestsversions insetup.pyandrequirements.txt, but it is another commit, so you can merge only Python 3 stuff if you don't want to mess with dependencies.