-
Notifications
You must be signed in to change notification settings - Fork 47
doc: add error messages #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
doc: add error messages #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Collaborator
|
Thank you for this PR 👍 I think the structure where the name of the module/instruction is in capital at the beginning is really helpful, it's there most of the time but not everywhere. The error messages should have the same format as well ( start with capital letters etc). I can go over it to unify it tmr if not done already 👌 I approved if you'd rather merge |
amkCha
approved these changes
Oct 1, 2025
...a/net/consensys/linea/zktracer/instructionprocessing/callTests/prc/ecmul/MemoryContents.java
Outdated
Show resolved
Hide resolved
...a/net/consensys/linea/zktracer/instructionprocessing/callTests/prc/ecadd/MemoryContents.java
Outdated
Show resolved
Hide resolved
jonesho
pushed a commit
that referenced
this pull request
Nov 24, 2025
Signed-off-by: F Bojarski <[email protected]> Co-authored-by: Olivier Bégassat <[email protected]> Co-authored-by: Olivier Bégassat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds explicit error messages to numerous precondition checks, renames RIPEMD block counter helper, and performs small API/cleanup tweaks (e.g., computePcNew signature).
checkArgument/checkStateacrosshubsections, precompile ops (BLS/EC/EXP), MMU/MXP/STP, txndata, utils, and runtime classes for clearer failures.numberOfRipemd160locks->numberOfRipemd160Blocksand update usages/tests (RipemdBlocks,RipTests).CommonFragmentValues.computePcNew(...)signature (dropHubparam) and update callers.TraceSections.previousSection(); tightenpreviousSection(int)with a message.Written by Cursor Bugbot for commit fb66a43. This will update automatically on new commits. Configure here.