Skip to content

Conversation

@letypequividelespoubelles
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles commented Sep 30, 2025

Note

Adds explicit error messages to numerous precondition checks, renames RIPEMD block counter helper, and performs small API/cleanup tweaks (e.g., computePcNew signature).

  • Diagnostics / Assertions:
    • Add explicit messages to checkArgument/checkState across hub sections, precompile ops (BLS/EC/EXP), MMU/MXP/STP, txndata, utils, and runtime classes for clearer failures.
  • Precompile Limits (RIPEMD):
    • Rename numberOfRipemd160locks -> numberOfRipemd160Blocks and update usages/tests (RipemdBlocks, RipTests).
  • APIs / Cleanups:
    • Change CommonFragmentValues.computePcNew(...) signature (drop Hub param) and update callers.
    • Remove TraceSections.previousSection(); tighten previousSection(int) with a message.
    • Minor import and message wording tweaks (e.g., “temporarily update the target limb”, more specific module/tag prefixes).

Written by Cursor Bugbot for commit fb66a43. This will update automatically on new commits. Configure here.

Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles letypequividelespoubelles linked an issue Sep 30, 2025 that may be closed by this pull request
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@amkCha
Copy link
Collaborator

amkCha commented Oct 1, 2025

Thank you for this PR 👍 I think the structure where the name of the module/instruction is in capital at the beginning is really helpful, it's there most of the time but not everywhere. The error messages should have the same format as well ( start with capital letters etc). I can go over it to unify it tmr if not done already 👌 I approved if you'd rather merge

@OlivierBBB OlivierBBB merged commit 16adf96 into arith-dev Oct 2, 2025
15 checks passed
@OlivierBBB OlivierBBB deleted the 2364-docs-add-error-messages branch October 2, 2025 09:25
jonesho pushed a commit that referenced this pull request Nov 24, 2025
Signed-off-by: F Bojarski <[email protected]>
Co-authored-by: Olivier Bégassat <[email protected]>
Co-authored-by: Olivier Bégassat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: add error messages

4 participants