feat: add logging for signer & validator set #1723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: SET-460 Add logging for validator set * feat: SET-460 refactor code to make it 1 liner * feat: SET-460 replace warn -> debug logs
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify debugging validator set related issues
Problem Statement:
Given a quorum IBFT network, with a validator set that is a subset of the network
When a node that is not part of the validator set sends consensus message, the receiving node will log an error:
Failed to decode message from payloadIn here, the receiving node does an
ecrecoveron the message sent, but the address recovered is not part of the validator setLogging here not sufficient to determine:
Solution
validatorSet& sender nodeaddresswhen error occurs (on DEBUG mode)