Skip to content

linting: remove unnecessary dependson #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

linting: remove unnecessary dependson #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions modules/cs-ioa-deployment.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ module keyVaultDiagnosticSetting 'ioa/keyVaultDiagnosticSetting.bicep' = {
storageAccountName: csLogStorage.outputs.storageAccountName
}
dependsOn: [
csLogStorage
csLogStorageEncryption
]
}
Expand Down Expand Up @@ -292,7 +291,6 @@ module activityLogFunction 'ioa/functionApp.bicep' = {
dependsOn: [
activityLogStorage
activityLogStorageEncryption
activityLogFunctionIdentity
]
}

Expand Down Expand Up @@ -336,17 +334,16 @@ module entraLogFunction 'ioa/functionApp.bicep' = {
dependsOn: [
entraLogStorage
entraLogStorageEncryption
entraLogFunctionIdentity
]
}

module activityDiagnosticSettings 'ioa/activityLog.bicep' = if (deployActivityLogDiagnosticSettings) {
name: '${deploymentNamePrefix}-activityLog-${deploymentNameSuffix}'
name: '${deploymentNamePrefix}-activityLog-${deploymentNameSuffix}'
scope: subscription(subscriptionId)
params: {
diagnosticSettingsName: activityLogSettings.diagnosticSettingsName
eventHubAuthorizationRuleId: eventHub.outputs.eventHubAuthorizationRuleId
eventHubName: eventHub.outputs.activityLogEventHubName
diagnosticSettingsName: activityLogSettings.diagnosticSettingsName
eventHubAuthorizationRuleId: eventHub.outputs.eventHubAuthorizationRuleId
eventHubName: eventHub.outputs.activityLogEventHubName
}
}

Expand Down
6 changes: 0 additions & 6 deletions modules/iom/azureSubscription.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@ module azureAccount 'azureAccount.bicep' = {
azureAccountType: azureAccountType
targetScope: targetScope
}
dependsOn: [
azureAppRegistration
]
}

/* Update Application Registration with Falcon provided certificate */
Expand All @@ -118,9 +115,6 @@ module azureAppRegistrationUpdate 'azureAppRegistration.bicep' = if (!useExistin
publicCertificate: azureAccount.outputs.azurePublicCertificate
grantAdminConsent: grantAppRegistrationAdminConsent
}
dependsOn: [
azureAccount
]
}

/* Define required permissions at Azure Subscription scope */
Expand Down