Add casts from SSLOptionType to c_long, required with OpenSSL 3+ on Windows
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indows Where SSLOptionType is ulong (on all platforms since v3), but c_long is 32-bit (Windows-specific). This fixes compilation errors when using SSL_CTX_set_mode() etc.
CyberShadow
approved these changes
Sep 26, 2024
|
That was quick, thx Vladimir! |
Closed
|
Cheers, do you need a tag? |
|
We already have a workaround, but surely wouldn't mind switching to upstream again, if it's not too much of a hassle and you don't plan another release soon anyway. |
|
Done, also sent an invite just in case bus factor becomes an issue in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where SSLOptionType is ulong (on all platforms since v3), but c_long is 32-bit (Windows-specific). This fixes compilation errors when using SSL_CTX_set_mode() etc.