Refactor and simplify social login functionality #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/teambiund/bander/auth_server/controller/SocialLoginController.java: deviceId 파라미터 제거 및 관련 코드 삭제 src/main/java/com/teambiund/bander/auth_server/service/login/LoginService.java: generateLoginResponse 메서드 시그니처에서 deviceId 제거 src/main/java/com/teambiund/bander/auth_server/service/social/SocialLoginService.java: 카카오/애플 로그인 로직에서 deviceId 관련 부분 삭제 src/main/java/com/teambiund/bander/auth_server/service/login/LoginServiceImpl.java: generateLoginResponse 내부 deviceId 생성/저장 로직 제거 참고: 해당 변경으로 LoginResponse에서 deviceId 필드가 제거되었을 수 있으니 클라이언트 영향 확인 필요 Signed-off-by: ddingjoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
deviceId처리 로직을 제거하고, 로직을 간소화하기 위해 이 PR이 필요합니다.변경 요약
deviceId파라미터 제거 및 관련 코드 삭제generateLoginResponse메서드에서deviceId생성 및 저장 로직 제거deviceId필드 제거 가능성)수용 기준 검증
브레이킹/마이그레이션
LoginResponse에서deviceId필드 제거로 인해 클라이언트와 서버 간 호환성 검토 필요테스트
참조