Support for Darwin clang toolchain #3284
Open
+67
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsManjeet
commented
Oct 13, 2025
itsManjeet
force-pushed
the
darwin-support
branch
from
fc996aa to
a27bfa6
Compare
|
Should this be called "darwin" or "macos"? Not sure what other build systems use. |
Either will work, but both Clang and CMake prefer darwin, which is why I used darwin. |
Agree to use darwin. |
| cmake -E env CFLAGS="${{ matrix.configurations }} -DLIBSPDM_DEBUG_LIBSPDM_ASSERT_CONFIG=3" cmake -DARCH=${{ matrix.arch }} -DTOOLCHAIN=${{ matrix.toolchain }} -DTARGET=${{ matrix.target }} -DCRYPTO=${{ matrix.crypto }} .. | ||
| cp -a ../unit_test/sample_key/* bin/ | ||
| cp -a ../unit_test/fuzzing/* bin/ && rm -rf bin/test_spdm_common bin/test_spdm_crypt | ||
| make -j1 # process killed with nproc |
There was a problem hiding this comment.
See, for example, zipper177/SatDump@d9e3b15.
There was a problem hiding this comment.
@itsManjeet this is still unresolved.
itsManjeet
force-pushed
the
darwin-support
branch
from
a27bfa6 to
26a6b46
Compare
Added CMake configurations to support build on darwin clang toolchain Tested for following configurations - ARCH=aarch64 CRYPTO=openssl TOOLCHAIN=CLANG Signed-off-by: itsManjeet <[email protected]>
itsManjeet
force-pushed
the
darwin-support
branch
from
26a6b46 to
584b9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CMake configurations to support build on darwin clang toolchain Tested for following configurations