Mathjax only on specific pages #3276
Open
+53
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes downloading the public scoreboard ZIP
nickygerritsen
changed the title
Member
Author
|
@vmcj if this works / is merged, will you cherry-pick it on your PR to |
meisterT
approved these changes
Dec 1, 2025
Member
Sure, but I still want to understand the issue. |
vmcj
added a commit
to vmcj/domjudge
that referenced
this pull request
Dec 21, 2025
Found while debugging the MathJax issue (DOMjudge#3276), MathJax requires the `mathjaxfonts` to be specified in the config. We parse that URL and try to add that directory to the zip which fails.
Member
|
I do understand the problem now, and think your solution would make the resulting zip already smaller. I've opened (#3309) to address the underlying issue. |
vmcj
approved these changes
Dec 21, 2025
Member
|
Should we still merge this? we don´t need that branch anymore IMO. |
Member
Author
|
Is Mathjax on main now? If so, we should retarget that branch. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
Found while debugging the MathJax issue (#3276), MathJax requires the `mathjaxfonts` to be specified in the config. We parse that URL and try to add that directory to the zip which fails.
Member
I suspect we don´t have it yet, and @tuupke found an issue on the NWERC branch still which we need to investigate, although I think one of the fixes is your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes downloading the public scoreboard ZIP