Lots of refactoring - Nilay has tested. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hschellman
commented
Aug 20, 2025
Collaborator
Author
There was a problem hiding this comment.
Lots of changes - added in a dataset viewer discussion
hschellman
commented
Aug 29, 2025
Collaborator
Author
hschellman
left a comment
hschellman
left a comment
There was a problem hiding this comment.
Lots of rearrangement - new philosophy is to put common code in _includes and reference but that breaks some callouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new model puts code in _includes and then uses it throughout using include directives.
Bad news is that includes cannot go into callouts.
Also a lot of back and forth on tokens for AL9/SL7.