NUKE alphaAddOne bit in color modulate #1866
Open
+5
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no differences in my screenshot test suite as a result of removing this. This alpha := 1 thing only existed in the `generic` shader; its absence in lightMapping is further evidence suggesting it is not needed. Note: this would open opportunities for further improvements/cleanup/simplification, due to e.g. the now unused spot in the float color modulate array, but I'm about to NUKE a large part of this code on the 0.56 branch so let's not touch it.
Also add a static assert that the descriptions list has the right size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the
alphaAddOnebit in color modulate uniforms. There are no differences in my screenshot test suite as a result of removing this. This alpha := 1 thing only existed in thegenericshader; its absence in lightMapping is further evidence suggesting it is not needed.Note: this would open opportunities for further improvements/cleanup/simplification, due to e.g. the now unused spot in the float color modulate array, but I'm about to NUKE a large part of this code on the 0.56 branch so let's not touch it.
Also fix wrong stage variant description strings in
/listMaterialSystemStages.