r_showVertexColors - don't black out generic shader #1868
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When r_showVertexColors is enabled, the lightMapping shader draws just the vertex colors. But the `generic` shader inexplicably was setting the color to (0, 0, 0, 0). Don't do that. It's stupid because it breaks the console and 2D drawing and does not help debugging.
VReaperV
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When r_showVertexColors is enabled, the lightMapping shader draws just the vertex colors. But the
genericshader inexplicably was setting the color to (0, 0, 0, 0). Don't do that. It's stupid because it breaks the console and 2D drawing and does not help debugging.