r_forceBlendRegime to load legacy lightmaps in linear space or vice versa #1869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow loading maps with sRGB lightmaps with naive blending, or maps with non-sRGB lightmaps with linear blending. Use
r_forceBlendRegime 1for naive blending orr_forceBlendRegime 2for linear blending.TODO: models and vertex lighting. Out of precomputed lighting, just lightmaps work so far.
From some examples you can see that non-blended surfaces look similar between blend modes. Use of multi-texturing features like normal and specular increases the difference. But even non-blended, non-lit surfaces like the skybox can still have visible differences because texture filtering produces different results when the image is flagged as sRGB.
All screenshots are made with tonemapping disabled.
Non-sRGB lightmaps, naive blending:
Non-sRGB lightmaps, linear blending (new!):
sRGB lightmaps, linear blending:
sRGB lightmaps, naive blending (new!):