Implement Post Editing #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongJun-H
reviewed
Sep 7, 2025
Comment on lines
346
to
354
| if (isPostEditMode) { | ||
| PostEditImages(images = postImages) | ||
| } else { | ||
| WriteUploadImages( | ||
| images = processedImages, | ||
| deleteImage = { index -> deleteImageUri(index) }, | ||
| onEditImage = { index -> editImage(index) }, | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
WriteUploadImages 내부에서 editMode로 분기처리하면 더 복잡해질까요??
Member
Author
There was a problem hiding this comment.
별도의 변수로 관리하고 있었고, 추후 다른 디자인 가능성에 따라 분리된 컴포저블로 만들었었습니다.
아래 리뷰처럼 ImageAsset으로 통합하고 하나의 processedImages로 관리한 뒤, 내부에서 분기하도록 변경하겠습니다
Comment on lines
86
to
87
| private val _postImages = MutableStateFlow<List<String>>(emptyList()) | ||
| val postImages = _postImages.asStateFlow() |
Member
There was a problem hiding this comment.
image관련 변수를 2개 유지하는 것보다 ImageAsset data class쪽을 확장시켜서 하나로 통합해서 관리하는게 더 좋지않을까요?
Comment on lines
301
to
306
| private fun setPostEditImages(images: List<String>) { | ||
| viewModelScope.launch { | ||
| _postImages.emit(images) | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
addOriginalImages(uris: List) 와 통합해서 사용하면 좋지않을까요?
Member
Author
There was a problem hiding this comment.
addOriginalImages에서는 readExifInfo를 통해서 exif 정보를 가져오도록 하는데, 서버에서 불러온 이미지는 contentResolver를 통해 정보를 불러 올 수 없어서 따로 처리 했습니다.
…nto writeImagesUri
DongJun-H
approved these changes
Sep 9, 2025
Member
Author
|
@DongJun-H 글 작성화면에서 BackHandler가 제대로 동작하지 않는 문제도 추가로 수정했습니닷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
글 수정하기 기능
a. 글 작성하기 화면을 재사용 하므로 editMode인 경우에만 정보를 불러오며, postEditId가 null일 때 한 번만 불러오도록 합니다.
b. 불러올 수 없는 경우 메시지를 보여주고 이전 화면으로 돌아갑니다.
게시글 작성
기타
참고