Skip to content

Syntax: Update syntax for Style/SlicingWithRange #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Syntax: Update syntax for Style/SlicingWithRange #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .standard_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ ignore:
- lib/csvlint/csvw/date_format.rb:
- Lint/MixedRegexpCaptureTypes
- lib/csvlint/csvw/number_format.rb:
- Style/SlicingWithRange
- Style/IdenticalConditionalBranches
- lib/csvlint/csvw/property_checker.rb:
- Performance/InefficientHashSearch
- Lint/UselessAssignment
- Naming/VariableName
- Style/SlicingWithRange
- Security/Open
- Lint/BooleanSymbol
- lib/csvlint/csvw/table_group.rb:
Expand All @@ -25,7 +23,6 @@ ignore:
- lib/csvlint/schema.rb:
- Security/Open
- Lint/UselessAssignment
- Style/SlicingWithRange
- lib/csvlint/validate.rb:
- Lint/UselessAssignment
- Performance/Count
Expand Down
4 changes: 2 additions & 2 deletions lib/csvlint/csvw/number_format.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def initialize(pattern = nil, grouping_separator = nil, decimal_separator = ".",

if ["+", "-"].include?(integer_part[0])
numeric_part_regexp = "\\#{integer_part[0]}"
integer_part = integer_part[1..-1]
integer_part = integer_part[1..]
else
numeric_part_regexp = "[-+]?"
end
Expand All @@ -52,7 +52,7 @@ def initialize(pattern = nil, grouping_separator = nil, decimal_separator = ".",
min_exponent_digits = exponent_part.delete("#").length
max_exponent_digits = exponent_part.length

integer_parts = integer_part.split(@grouping_separator)[1..-1]
integer_parts = integer_part.split(@grouping_separator)[1..]
@primary_grouping_size = begin
integer_parts[-1].length
rescue
Expand Down
2 changes: 1 addition & 1 deletion lib/csvlint/csvw/property_checker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def column_reference_property(type)
if value.instance_of? String
schema_url = URI.join(base_url, value).to_s
schema_base_url = schema_url
schema_ref = schema_url.start_with?("file:") ? File.new(schema_url[5..-1]) : schema_url
schema_ref = schema_url.start_with?("file:") ? File.new(schema_url[5..]) : schema_url
schema = JSON.parse(URI.open(schema_ref).read)
schema["@id"] = schema["@id"] ? URI.join(schema_url, schema["@id"]).to_s : schema_url
if schema["@context"]
Expand Down
4 changes: 2 additions & 2 deletions lib/csvlint/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ def validate_header(header, source_url = nil, validate = true)
def validate_row(values, row = nil, all_errors = [], source_url = nil, validate = true)
reset
if values.length < fields.length
fields[values.size..-1].each_with_index do |field, i|
fields[values.size..].each_with_index do |field, i|
build_warnings(:missing_column, :schema, row, values.size + i + 1)
end
end
if values.length > fields.length
values[fields.size..-1].each_with_index do |data_column, i|
values[fields.size..].each_with_index do |data_column, i|
build_warnings(:extra_column, :schema, row, fields.size + i + 1)
end
end
Expand Down
Loading