Skip to content

Conversation

@MatthewBemis
Copy link
Member

@MatthewBemis MatthewBemis commented Oct 17, 2025

Jira Ticket: https://broadworkbench.atlassian.net/browse/TSPS-645

Summary of changes:

  • Improves error handling in the Run Job page
  • Refactors the handleSubmit function to be easier to read (imo)

What

Screen.Recording.2025-10-17.at.12.35.27.PM.mov

Why

Testing strategy

fetchData();
}, [signal]);

const handleSubmit = async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function had gotten a bit gnarly- there was some cruft leftover from earlier days of development. i took this opportunity to clean it up and hopefully make a rather complicated sequence of api calls easier to follow

@MatthewBemis MatthewBemis marked this pull request as ready for review October 17, 2025 17:35
Copy link
Contributor

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, so much easier to understand what's happening now.

notify('error', 'No pipeline selected or pipeline name not found');
return;
}
const pipelineName = selectedPipeline.pipelineName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much simpler!

Copy link

@jsotobroad jsotobroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice win for sure

@MatthewBemis MatthewBemis requested a review from a team as a code owner October 20, 2025 17:54
@sonarqubecloud
Copy link

@MatthewBemis MatthewBemis added this pull request to the merge queue Oct 20, 2025
Merged via the queue into dev with commit b1a9d55 Oct 20, 2025
11 checks passed
@MatthewBemis MatthewBemis deleted the mb-tsps-645-fix-submission-hang branch October 20, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants