Skip to content

Conversation

@NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Jun 12, 2025

Reverts #37869

Doc PR: DataDog/documentation#29728

Motivation

Fix the original feature PR: #35636

@NouemanKHAL NouemanKHAL requested review from a team as code owners June 12, 2025 10:08
@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2025

View all feedbacks in Devflow UI.

2025-06-12 10:08:22 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on
If you need support, contact us on Slack #devflow!


2025-06-12 10:11:26 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Details
child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: 1be37f58-b3db-43f8-8083-bd77a83465f5_26, runID: 76c34497-117b-47b9-8663-2538e2ed1e3e, initiatedEventID: 26, startedEventID: 27): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: 76c34497-117b-47b9-8663-2538e2ed1e3e_14, runID: 4f22bf90-647f-43be-95f4-558944ec6db3, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: Error, retryable: true): net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: timeoutError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@NouemanKHAL NouemanKHAL added the qa/done QA done before merge and regressions are covered by tests label Jun 12, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 12, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 55246242-9491-4661-ae8c-d34c83bc75a5

Baseline: a64d579
Comparison: 4561f1f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.27 [-0.49, +5.03] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.96 [+0.90, +1.03] 1 Logs
otlp_ingest_metrics memory utilization +0.77 [+0.61, +0.93] 1 Logs
otlp_ingest_logs memory utilization +0.49 [+0.36, +0.62] 1 Logs
file_tree memory utilization +0.25 [+0.11, +0.39] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.17 [-0.72, +1.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.07 [-0.51, +0.66] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.00 [-0.23, +0.24] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.27, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.67, +0.61] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.03 [-0.63, +0.58] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.05 [-0.61, +0.51] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.09 [-0.74, +0.56] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.74, +0.56] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.10 [-0.71, +0.50] 1 Logs
ddot_logs memory utilization -0.24 [-0.33, -0.15] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.26 [-0.31, -0.22] 1 Logs
ddot_metrics memory utilization -0.32 [-0.44, -0.20] 1 Logs
docker_containers_memory memory utilization -0.35 [-0.41, -0.30] 1 Logs
docker_containers_cpu % cpu utilization -0.39 [-3.32, +2.53] 1 Logs
quality_gate_idle memory utilization -0.45 [-0.51, -0.39] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.63 [-0.73, -0.53] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 12, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a64d579

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${697.29}$$ < $${697.37}$$ $${+0.01}$$ $${176.09}$$ < $${177.03}$$
agent_deb_amd64_fips $${+0}$$ $${695.55}$$ < $${695.59}$$ $${+0.05}$$ $${175.57}$$ < $${176.51}$$
agent_heroku_amd64 $${+0}$$ $${349.05}$$ < $${359.67}$$ $${+0.01}$$ $${93.65}$$ < $${97.47}$$
agent_msi $${+0}$$ $${959.26}$$ < $${959.86}$$ $${+0.02}$$ $${146.27}$$ < $${147.27}$$
agent_rpm_amd64 $${+0}$$ $${697.28}$$ < $${697.36}$$ $${-0}$$ $${177.66}$$ < $${178.56}$$
agent_rpm_amd64_fips $${+0}$$ $${695.54}$$ < $${695.58}$$ $${-0}$$ $${177.56}$$ < $${178.43}$$
agent_rpm_arm64 $${+0}$$ $${687.29}$$ < $${687.37}$$ $${+0.06}$$ $${161.2}$$ < $${161.99}$$
agent_rpm_arm64_fips $${+0}$$ $${685.67}$$ < $${685.72}$$ $${-0.01}$$ $${160.25}$$ < $${161.11}$$
agent_suse_amd64 $${+0}$$ $${697.28}$$ < $${697.36}$$ $${-0}$$ $${177.66}$$ < $${178.56}$$
agent_suse_amd64_fips $${+0}$$ $${695.54}$$ < $${695.58}$$ $${-0}$$ $${177.56}$$ < $${178.43}$$
agent_suse_arm64 $${+0}$$ $${687.29}$$ < $${687.37}$$ $${+0.06}$$ $${161.2}$$ < $${161.99}$$
agent_suse_arm64_fips $${+0}$$ $${685.67}$$ < $${685.72}$$ $${-0.01}$$ $${160.25}$$ < $${161.11}$$
docker_agent_amd64 $${+0}$$ $${781.09}$$ < $${781.16}$$ $${-0}$$ $${268.84}$$ < $${269.63}$$
docker_agent_arm64 $${+0}$$ $${794.55}$$ < $${794.62}$$ $${-0}$$ $${256.17}$$ < $${257.0}$$
docker_agent_jmx_amd64 $${+0}$$ $${972.28}$$ < $${972.35}$$ $${+0}$$ $${337.81}$$ < $${338.6}$$
docker_agent_jmx_arm64 $${+0}$$ $${974.34}$$ < $${974.41}$$ $${+0}$$ $${321.14}$$ < $${321.97}$$
docker_agent_windows1809 $${-0.94}$$ $${1179.87}$$ < $${1185.29}$$ $${-0.7}$$ $${415.49}$$ < $${420.95}$$
docker_agent_windows1809_core $${-0}$$ $${5910.77}$$ < $${5915.25}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows1809_core_jmx $${-0}$$ $${6032.34}$$ < $${6059.4}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows1809_jmx $${-0.01}$$ $${1302.44}$$ < $${1306.92}$$ $${+0}$$ $${458.49}$$ < $${463.21}$$
docker_agent_windows2022 $${+0}$$ $${1200.15}$$ < $${1204.42}$$ $${+0.01}$$ $${428.94}$$ < $${433.71}$$
docker_agent_windows2022_core $${+0.19}$$ $${5884.03}$$ < $${5888.56}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows2022_core_jmx $${-0.03}$$ $${6005.51}$$ < $${6009.95}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows2022_jmx $${+0.01}$$ $${1321.51}$$ < $${1326.13}$$ $${-0.03}$$ $${471.19}$$ < $${475.99}$$
docker_cluster_agent_amd64 $${0}$$ $${212.9}$$ < $${213.79}$$ $${-0}$$ $${72.41}$$ < $${73.33}$$
docker_cluster_agent_arm64 $${0}$$ $${228.76}$$ < $${229.64}$$ $${+0}$$ $${68.68}$$ < $${69.6}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${39.23}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.88}$$ < $${38.2}$$ $${-0}$$ $${14.53}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.46}$$ < $${31.4}$$ $${+0}$$ $${8.0}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${29.03}$$ < $${29.97}$$ $${+0}$$ $${6.94}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.46}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${30.46}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${50.48}$$ < $${51.38}$$ $${-0}$$ $${12.85}$$ < $${13.79}$$
iot_agent_deb_arm64 $${0}$$ $${47.95}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.09}$$
iot_agent_deb_armhf $${0}$$ $${47.52}$$ < $${48.42}$$ $${-0}$$ $${11.21}$$ < $${12.16}$$
iot_agent_rpm_amd64 $${0}$$ $${50.48}$$ < $${51.38}$$ $${+0}$$ $${12.87}$$ < $${13.81}$$
iot_agent_rpm_arm64 $${0}$$ $${47.95}$$ < $${48.85}$$ $${+0}$$ $${11.17}$$ < $${12.11}$$
iot_agent_suse_amd64 $${0}$$ $${50.48}$$ < $${51.38}$$ $${+0}$$ $${12.87}$$ < $${13.81}$$

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 16, 2025

View all feedbacks in Devflow UI.

2025-06-16 22:56:46 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-06-16 22:58:44 UTC ℹ️ Gitlab pipeline started

Started pipeline #67928918

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 17, 2025

View all feedbacks in Devflow UI.

2025-06-17 07:42:14 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-06-17 07:43:12 UTC ℹ️ Gitlab pipeline started

Started pipeline #67945426

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 17, 2025
@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 17, 2025

View all feedbacks in Devflow UI.

2025-06-17 12:52:18 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-06-17 12:53:14 UTC ℹ️ Gitlab pipeline started

Started pipeline #67973678

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 18, 2025

View all feedbacks in Devflow UI.

2025-06-18 10:51:54 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-06-18 10:52:53 UTC ℹ️ Gitlab pipeline started

Started pipeline #68090867

@NouemanKHAL NouemanKHAL added the ask-review Ask required teams to review this PR label Jun 18, 2025
if os.name == "nt":
flag_path = os.path.join(storage_location, ".skip_install_python_third_party_deps")

if not os.path.exists(flag_path) or skip_flag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the skip flag now, as we don't need it for windows if it is on by default. This was mainly for making sure that it would always run based on MSI flags on windows.

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2025

View all feedbacks in Devflow UI.

2025-06-24 08:43:50 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-06-24 08:44:48 UTC ℹ️ Gitlab pipeline started

Started pipeline #68566585

@NouemanKHAL
Copy link
Member Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 25, 2025

View all feedbacks in Devflow UI.

2025-06-25 09:17:06 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-06-25 09:19:07 UTC ℹ️ Gitlab pipeline started

Started pipeline #68704835

@NouemanKHAL NouemanKHAL requested a review from jack0x2 June 25, 2025 13:32
@NouemanKHAL
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 25, 2025

View all feedbacks in Devflow UI.

2025-06-25 13:43:21 UTC ℹ️ Start processing command /merge


2025-06-25 13:43:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2025-06-25 14:23:45 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 05a9e64 into main Jun 25, 2025
546 checks passed
@dd-mergequeue dd-mergequeue bot deleted the revert-37869-chouquette/revert branch June 25, 2025 14:23
@github-actions github-actions bot added this to the 7.69.0 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR [deprecated] team/container-ecosystems [deprecated] team/windows-agent medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-delivery team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants