Skip to content

Conversation

@FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jul 4, 2025

What does this PR do?

Create a release branch in test-infra-defintions after the cut-off, in case we need it later.

The branch is created on the commit that is currently used in the repo

Motivation

https://datadoghq.atlassian.net/browse/BARX-1074

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-delivery short review PR is simple enough to be reviewed quickly labels Jul 4, 2025
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 4, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jul 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0f0420f0-38af-42d7-8912-0fc164594b8d

Baseline: 08a56af
Comparison: 8f60a77
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.75 [+0.89, +2.60] 1 Logs
quality_gate_idle memory utilization +0.76 [+0.68, +0.83] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.67 [+0.54, +0.80] 1 Logs
quality_gate_logs % cpu utilization +0.46 [-2.34, +3.26] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +0.35 [-2.72, +3.42] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.25 [+0.18, +0.31] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.11 [+0.04, +0.19] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.08 [-0.15, +0.32] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.52, +0.64] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.56, +0.63] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.26, +0.26] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.55, +0.54] 1 Logs
ddot_metrics memory utilization -0.04 [-0.16, +0.08] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.59, +0.48] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.75, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.11 [-0.69, +0.48] 1 Logs
otlp_ingest_metrics memory utilization -0.12 [-0.27, +0.02] 1 Logs
file_tree memory utilization -0.13 [-0.27, +0.01] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.16 [-0.80, +0.49] 1 Logs
quality_gate_idle_all_features memory utilization -0.17 [-0.25, -0.09] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.34 [-0.41, -0.26] 1 Logs
ddot_logs memory utilization -0.54 [-0.63, -0.45] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_logs memory_usage 9/10 bounds checks dashboard
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@FlorentClarret FlorentClarret force-pushed the florentclarret/test-infra-definitions-release-branch- branch from ba3ebbf to a464d7d Compare July 4, 2025 11:09
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jul 4, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 08a56af

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${696.1}$$ < $${700.55}$$ $${-0}$$ $${175.88}$$ < $${177.62}$$
agent_deb_amd64_fips $${0}$$ $${694.36}$$ < $${699.75}$$ $${+0.01}$$ $${175.36}$$ < $${177.04}$$
agent_heroku_amd64 $${0}$$ $${349.11}$$ < $${362.84}$$ $${+0}$$ $${93.56}$$ < $${98.91}$$
agent_msi $${0}$$ $${971.13}$$ < $${974.5}$$ $${0}$$ $${147.25}$$ < $${148.11}$$
agent_rpm_amd64 $${0}$$ $${696.09}$$ < $${700.53}$$ $${+0.01}$$ $${177.55}$$ < $${179.2}$$
agent_rpm_amd64_fips $${0}$$ $${694.35}$$ < $${699.74}$$ $${+0}$$ $${177.24}$$ < $${178.75}$$
agent_rpm_arm64 $${0}$$ $${686.31}$$ < $${690.5}$$ $${+0.05}$$ $${161.11}$$ < $${162.56}$$
agent_rpm_arm64_fips $${0}$$ $${684.62}$$ < $${689.8}$$ $${+0.01}$$ $${160.14}$$ < $${161.61}$$
agent_suse_amd64 $${0}$$ $${696.09}$$ < $${700.54}$$ $${+0.01}$$ $${177.55}$$ < $${179.2}$$
agent_suse_amd64_fips $${0}$$ $${694.35}$$ < $${699.74}$$ $${+0}$$ $${177.24}$$ < $${178.93}$$
agent_suse_arm64 $${0}$$ $${686.31}$$ < $${690.43}$$ $${+0.05}$$ $${161.11}$$ < $${162.57}$$
agent_suse_arm64_fips $${0}$$ $${684.62}$$ < $${689.78}$$ $${+0.01}$$ $${160.14}$$ < $${161.61}$$
docker_agent_amd64 $${-0}$$ $${779.89}$$ < $${784.33}$$ $${-0}$$ $${268.63}$$ < $${270.56}$$
docker_agent_arm64 $${-0}$$ $${793.56}$$ < $${797.68}$$ $${-0}$$ $${256.02}$$ < $${257.84}$$
docker_agent_jmx_amd64 $${-0}$$ $${971.09}$$ < $${975.52}$$ $${+0}$$ $${337.6}$$ < $${339.53}$$
docker_agent_jmx_arm64 $${-0}$$ $${973.35}$$ < $${977.47}$$ $${+0.01}$$ $${320.95}$$ < $${322.81}$$
docker_agent_windows1809 $${-0}$$ $${1183.99}$$ < $${1190.0}$$ $${+0.05}$$ $${417.55}$$ < $${422.66}$$
docker_agent_windows1809_core $${+0}$$ $${5913.95}$$ < $${5919.41}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows1809_core_jmx $${+0}$$ $${6035.52}$$ < $${6063.56}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows1809_jmx $${-0}$$ $${1305.61}$$ < $${1311.1}$$ $${+0.02}$$ $${459.85}$$ < $${464.35}$$
docker_agent_windows2022 $${+0.07}$$ $${1203.41}$$ < $${1208.75}$$ $${+0.03}$$ $${430.27}$$ < $${434.91}$$
docker_agent_windows2022_core $${-0}$$ $${5887.01}$$ < $${5892.66}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows2022_core_jmx $${+0}$$ $${6008.65}$$ < $${6014.08}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
docker_agent_windows2022_jmx $${+0.02}$$ $${1324.9}$$ < $${1330.39}$$ $${+0.01}$$ $${472.54}$$ < $${477.17}$$
docker_cluster_agent_amd64 $${-0}$$ $${213.63}$$ < $${214.5}$$ $${+0}$$ $${72.62}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${-0}$$ $${229.42}$$ < $${230.33}$$ $${+0}$$ $${68.89}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${39.21}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.54}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.42}$$ < $${31.4}$$ $${+0}$$ $${8.0}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.99}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.42}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${30.42}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${53.77}$$ < $${54.55}$$ $${-0}$$ $${13.55}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.11}$$ < $${51.9}$$ $${+0}$$ $${11.73}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${50.62}$$ < $${51.42}$$ $${+0}$$ $${11.83}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${53.77}$$ < $${54.55}$$ $${-0}$$ $${13.57}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${0}$$ $${51.11}$$ < $${51.91}$$ $${-0}$$ $${11.75}$$ < $${12.65}$$
iot_agent_suse_amd64 $${0}$$ $${53.77}$$ < $${54.55}$$ $${-0}$$ $${13.57}$$ < $${14.47}$$

@FlorentClarret FlorentClarret changed the title Automatically create a release branch in test-infra-definitions after the cut-off Create a release branch in test-infra-definitions after the cut-off Jul 4, 2025
@FlorentClarret FlorentClarret force-pushed the florentclarret/test-infra-definitions-release-branch- branch from a464d7d to a529f62 Compare July 4, 2025 12:51
@FlorentClarret FlorentClarret force-pushed the florentclarret/test-infra-definitions-release-branch- branch from a529f62 to e033df1 Compare July 4, 2025 13:08
@FlorentClarret FlorentClarret marked this pull request as ready for review July 4, 2025 14:55
@FlorentClarret FlorentClarret requested review from a team as code owners July 4, 2025 14:55
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 7, 2025

View all feedbacks in Devflow UI.

2025-07-07 15:47:36 UTC ℹ️ Start processing command /merge


2025-07-07 15:47:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 46m (p90).


2025-07-07 16:25:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ad6f2e9 into main Jul 7, 2025
231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/test-infra-definitions-release-branch- branch July 7, 2025 16:25
@github-actions github-actions bot added this to the 7.69.0 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants