feat(controller): implement monitor recreation with drift detection #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add drift detection to reconciliation loop to identify missing monitors - Implement handleMonitorRecreation method for automatic recreation - Add new condition types: DriftDetected, Recreated for status tracking - Enhance error handling for API unavailability, rate limiting, and validation - Add Kubernetes event emission for successful monitor recreations - Implement concurrent operation safety with optimistic locking - Add comprehensive property-based tests for all recreation scenarios - Add integration tests for end-to-end recreation workflow This feature automatically detects when monitors are deleted externally and recreates them while preserving configuration and maintaining proper status reporting. Closes: #monitor-recreation-feature Signed-off-by: Starlight Romero <[email protected]>
starlightromero
force-pushed
the
feat/monitor-recreation
branch
from
ec964ad to
d584238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements automatic monitor recreation with drift detection for the DatadogMonitor controller. When monitors are deleted externally from Datadog, the operator will automatically detect the drift and recreate the monitor while preserving the original configuration.
Key Features
Implementation Details
Core Changes
handleMonitorRecreation()method for recreation logicDriftDetectedandRecreatedcondition types to APIMonitorRecreatedevent type for Kubernetes eventsTesting
Test Results
All tests pass successfully:
Breaking Changes
None. This is a backward-compatible enhancement that adds new functionality without modifying existing behavior.
Related Issues
Implements monitor recreation feature for improved reliability and operational excellence.
Fixes #1962
Checklist