-
Notifications
You must be signed in to change notification settings - Fork 490
feat: store OTEL process context in named anonymous mapping on Linux #3937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+623
−3
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f705452
feat: store OTEL process context in named anonymous mapping on Linux
nsavoire 0111ebb
Address review comments
nsavoire 87f4825
Updated generated file
nsavoire 76e24fe
Add tests
nsavoire 04e8c3b
Merge branch 'main' into nsavoire/process_level_context
kakkoyun cb5af9f
Add documentation for storeConfig
nsavoire 8a6270e
Make RemoveOtelProcessContextMapping private
nsavoire b6dba06
Merge branch 'main' into nsavoire/process_level_context
kakkoyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Unless explicitly stated otherwise all files in this repository are licensed | ||
| // under the Apache License Version 2.0. | ||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2025 Datadog, Inc. | ||
| package tracer | ||
|
|
||
| // OtelProcessContext represents the OTEL context for the process. | ||
| // | ||
| //go:generate go run github.com/tinylib/msgp -unexported -marshal=true -o=otelprocesscontext_msgp.go -tests=false | ||
| type otelProcessContext struct { | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/deployment/#deployment-environment-name | ||
| DeploymentEnvironmentName string `msg:"deployment.environment.name"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/host/#host-name | ||
| HostName string `msg:"host.name"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/#service-instance-id | ||
| ServiceInstanceID string `msg:"service.instance.id"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/#service-name | ||
| ServiceName string `msg:"service.name"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/#service-version | ||
| ServiceVersion string `msg:"service.version"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/telemetry/#telemetry-sdk-language | ||
| TelemetrySDKLanguage string `msg:"telemetry.sdk.language"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/telemetry/#telemetry-sdk-version | ||
| TelemetrySDKVersion string `msg:"telemetry.sdk.version"` | ||
| // https://opentelemetry.io/docs/specs/semconv/registry/attributes/telemetry/#telemetry-sdk-name | ||
| TelemetrySdkName string `msg:"telemetry.sdk.name"` | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Unless explicitly stated otherwise all files in this repository are licensed | ||
| // under the Apache License Version 2.0. | ||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2025 Datadog, Inc. | ||
|
|
||
| //go:build !linux | ||
|
|
||
| package internal | ||
|
|
||
| func CreateOtelProcessContextMapping(data []byte) error { | ||
| return nil | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a doc that explains why were are not using the Memfd solution for OpenTelemetry? IIRC we had some good reason, but I forgot what it was. We should probably link to that doc here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://datadoghq.atlassian.net/wiki/spaces/PROF/pages/4951344716/In+progress+Sharing+Process+Level+Information+between+SDKs+and+the+full+host+profiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reasons were:
memfd_createsyscall might be blocked by some seccomp profiles/proc/<pid>/fd/need to be resolved untildatadog-tracer-info-<id>file is foundThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "not inherited by fork" is also a nice bonus, and connects back to the discussions happening internally on the meaning of "runtime-id" -- the anonymous mapping mechanism, because it's not inherited by forks won't have any issues with stale information (such as a runtime-id) being carried from parent to child process.