-
Notifications
You must be signed in to change notification settings - Fork 493
fix(ddtrace/tracer): ensure that sampling tests on remote config update are consistent #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…te are consistent
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 8cbbc2d | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
kakkoyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Tests failed on this commit 43256fb: What to do next?
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Modifies
TestOnRemoteConfigUpdateto ensure that we replace the pattern below with equivalentrequire.Equalcalls, as the test might pass without running some assertions.Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!