Skip to content

Conversation

@rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 30, 2025

What does this PR do?

Track usage of core llmobs apis.

Additionally, it renames the llmobs benchmark BenchmarkStartSpan to BenchmarkLLMObsStartSpan to not clash with the existing apm benchmark, and adds it to the .gitlab-ci.yml config.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2025

Benchmarks

Benchmark execution time: 2025-10-31 15:20:38

Comparing candidate commit 05de3d7 in PR branch rarguelloF/llmobs-telemetry with baseline commit 5ef8e9b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@rarguelloF rarguelloF marked this pull request as ready for review October 30, 2025 15:25
@rarguelloF rarguelloF requested review from a team as code owners October 30, 2025 15:25
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarguelloF rarguelloF requested a review from a team as a code owner October 30, 2025 17:33
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 30, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestMultipleSpanIntegrationTags from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog)
Failed

=== RUN   TestMultipleSpanIntegrationTags
    metrics_test.go:219: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:219
        	Error:      	Condition never satisfied
        	Test:       	TestMultipleSpanIntegrationTags
panic: not implemented

goroutine 1327 [running]:
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 05de3d7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@darccio darccio force-pushed the rarguelloF/llmobs-telemetry branch from 0a49f50 to 35b4637 Compare October 31, 2025 15:05
@darccio darccio force-pushed the rarguelloF/llmobs-telemetry branch from 9f15f55 to 05de3d7 Compare October 31, 2025 15:07
@darccio
Copy link
Member

darccio commented Oct 31, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 31, 2025

View all feedbacks in Devflow UI.

2025-10-31 15:09:48 UTC ℹ️ Start processing command /merge


2025-10-31 15:09:58 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-31 15:56:24 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-10-31 16:11:19 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot deleted the rarguelloF/llmobs-telemetry branch October 31, 2025 16:11
e-n-0 pushed a commit that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants