-
Notifications
You must be signed in to change notification settings - Fork 312
Implement APIGW with Context API #9398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: a68a992 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050972
Total [baseline] (10.76 s) : 0, 10760130
Agent [candidate] (1.056 s) : 0, 1056356
Total [candidate] (10.847 s) : 0, 10847355
section appsec
Agent [baseline] (1.235 s) : 0, 1235261
Total [baseline] (10.853 s) : 0, 10853266
Agent [candidate] (1.232 s) : 0, 1231614
Total [candidate] (10.881 s) : 0, 10881435
section iast
Agent [baseline] (1.178 s) : 0, 1177803
Total [baseline] (10.913 s) : 0, 10913000
Agent [candidate] (1.192 s) : 0, 1192308
Total [candidate] (11.006 s) : 0, 11005547
section profiling
Agent [baseline] (1.204 s) : 0, 1203786
Total [baseline] (10.918 s) : 0, 10917682
Agent [candidate] (1.198 s) : 0, 1198383
Total [candidate] (10.895 s) : 0, 10895103
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (734.824 ms) : 0, 734824
BytebuddyAgent [candidate] (738.819 ms) : 0, 738819
GlobalTracer [baseline] (243.766 ms) : 0, 243766
GlobalTracer [candidate] (244.678 ms) : 0, 244678
AppSec [baseline] (30.028 ms) : 0, 30028
AppSec [candidate] (30.521 ms) : 0, 30521
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.094 ms) : 0, 6094
Remote Config [baseline] (677.921 µs) : 0, 678
Remote Config [candidate] (679.884 µs) : 0, 680
Telemetry [baseline] (12.224 ms) : 0, 12224
Telemetry [candidate] (12.889 ms) : 0, 12889
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (763.227 ms) : 0, 763227
BytebuddyAgent [candidate] (761.353 ms) : 0, 761353
GlobalTracer [baseline] (238.038 ms) : 0, 238038
GlobalTracer [candidate] (237.367 ms) : 0, 237367
AppSec [baseline] (170.221 ms) : 0, 170221
AppSec [candidate] (170.136 ms) : 0, 170136
Debugger [baseline] (7.376 ms) : 0, 7376
Debugger [candidate] (7.139 ms) : 0, 7139
Remote Config [baseline] (631.492 µs) : 0, 631
Remote Config [candidate] (634.232 µs) : 0, 634
Telemetry [baseline] (9.272 ms) : 0, 9272
Telemetry [candidate] (8.423 ms) : 0, 8423
IAST [baseline] (23.716 ms) : 0, 23716
IAST [candidate] (23.825 ms) : 0, 23825
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (849.878 ms) : 0, 849878
BytebuddyAgent [candidate] (861.254 ms) : 0, 861254
GlobalTracer [baseline] (232.869 ms) : 0, 232869
GlobalTracer [candidate] (235.252 ms) : 0, 235252
AppSec [baseline] (26.862 ms) : 0, 26862
AppSec [candidate] (28.456 ms) : 0, 28456
Debugger [baseline] (8.197 ms) : 0, 8197
Debugger [candidate] (6.624 ms) : 0, 6624
Remote Config [baseline] (589.51 µs) : 0, 590
Remote Config [candidate] (599.343 µs) : 0, 599
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.386 ms) : 0, 8386
IAST [baseline] (28.57 ms) : 0, 28570
IAST [candidate] (29.013 ms) : 0, 29013
section profiling
ProfilingAgent [baseline] (109.05 ms) : 0, 109050
ProfilingAgent [candidate] (107.945 ms) : 0, 107945
crashtracking [baseline] (1.419 ms) : 0, 1419
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (766.912 ms) : 0, 766912
BytebuddyAgent [candidate] (763.425 ms) : 0, 763425
GlobalTracer [baseline] (223.588 ms) : 0, 223588
GlobalTracer [candidate] (222.409 ms) : 0, 222409
AppSec [baseline] (30.273 ms) : 0, 30273
AppSec [candidate] (30.03 ms) : 0, 30030
Debugger [baseline] (6.329 ms) : 0, 6329
Debugger [candidate] (6.296 ms) : 0, 6296
Remote Config [baseline] (738.33 µs) : 0, 738
Remote Config [candidate] (712.628 µs) : 0, 713
Telemetry [baseline] (15.628 ms) : 0, 15628
Telemetry [candidate] (16.453 ms) : 0, 16453
Profiling [baseline] (109.699 ms) : 0, 109699
Profiling [candidate] (108.587 ms) : 0, 108587
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049755
Total [baseline] (8.669 s) : 0, 8668989
Agent [candidate] (1.047 s) : 0, 1046838
Total [candidate] (8.62 s) : 0, 8619970
section iast
Agent [baseline] (1.184 s) : 0, 1183799
Total [baseline] (9.362 s) : 0, 9362462
Agent [candidate] (1.181 s) : 0, 1181493
Total [candidate] (9.362 s) : 0, 9362115
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (735.261 ms) : 0, 735261
BytebuddyAgent [candidate] (733.216 ms) : 0, 733216
GlobalTracer [baseline] (243.493 ms) : 0, 243493
GlobalTracer [candidate] (242.851 ms) : 0, 242851
AppSec [baseline] (30.189 ms) : 0, 30189
AppSec [candidate] (30.057 ms) : 0, 30057
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.024 ms) : 0, 6024
Remote Config [baseline] (678.745 µs) : 0, 679
Remote Config [candidate] (667.394 µs) : 0, 667
Telemetry [baseline] (11.532 ms) : 0, 11532
Telemetry [candidate] (11.575 ms) : 0, 11575
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (854.336 ms) : 0, 854336
BytebuddyAgent [candidate] (852.507 ms) : 0, 852507
GlobalTracer [baseline] (233.968 ms) : 0, 233968
GlobalTracer [candidate] (235.219 ms) : 0, 235219
AppSec [baseline] (26.868 ms) : 0, 26868
AppSec [candidate] (26.042 ms) : 0, 26042
Debugger [baseline] (6.614 ms) : 0, 6614
Debugger [candidate] (6.571 ms) : 0, 6571
Remote Config [baseline] (607.274 µs) : 0, 607
Remote Config [candidate] (601.377 µs) : 0, 601
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.432 ms) : 0, 8432
IAST [baseline] (30.613 ms) : 0, 30613
IAST [candidate] (29.68 ms) : 0, 29680
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section baseline
no_agent (36.658 ms) : 36363, 36953
. : milestone, 36658,
appsec (46.044 ms) : 45639, 46450
. : milestone, 46044,
code_origins (45.027 ms) : 44635, 45418
. : milestone, 45027,
iast (45.782 ms) : 45386, 46177
. : milestone, 45782,
profiling (47.798 ms) : 47382, 48213
. : milestone, 47798,
tracing (43.077 ms) : 42725, 43428
. : milestone, 43077,
section candidate
no_agent (37.449 ms) : 37134, 37763
. : milestone, 37449,
appsec (44.386 ms) : 44000, 44773
. : milestone, 44386,
code_origins (44.738 ms) : 44346, 45131
. : milestone, 44738,
iast (45.544 ms) : 45142, 45946
. : milestone, 45544,
profiling (46.311 ms) : 45889, 46734
. : milestone, 46311,
tracing (43.431 ms) : 43065, 43797
. : milestone, 43431,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section baseline
no_agent (4.33 ms) : 4276, 4384
. : milestone, 4330,
iast (9.489 ms) : 9329, 9650
. : milestone, 9489,
iast_FULL (13.62 ms) : 13348, 13891
. : milestone, 13620,
iast_GLOBAL (10.18 ms) : 9991, 10368
. : milestone, 10180,
profiling (9.016 ms) : 8866, 9166
. : milestone, 9016,
tracing (7.611 ms) : 7504, 7717
. : milestone, 7611,
section candidate
no_agent (4.385 ms) : 4331, 4439
. : milestone, 4385,
iast (8.737 ms) : 8593, 8881
. : milestone, 8737,
iast_FULL (9.654 ms) : 9460, 9848
. : milestone, 9654,
iast_GLOBAL (9.324 ms) : 9164, 9483
. : milestone, 9324,
profiling (8.49 ms) : 8356, 8623
. : milestone, 8490,
tracing (7.564 ms) : 7453, 7675
. : milestone, 7564,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1485
. : milestone, 1474,
appsec (3.65 ms) : 3432, 3869
. : milestone, 3650,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.242 ms) : 2178, 2305
. : milestone, 2242,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.659 ms) : 3441, 3876
. : milestone, 3659,
iast (2.186 ms) : 2123, 2248
. : milestone, 2186,
iast_GLOBAL (2.24 ms) : 2176, 2303
. : milestone, 2240,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.018 ms) : 1969, 2067
. : milestone, 2018,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~a68a992577, baseline=1.53.0-SNAPSHOT~5aa25baa32
dateFormat X
axisFormat %s
section baseline
no_agent (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
appsec (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
iast (18.552 s) : 18552000, 18552000
. : milestone, 18552000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
tracing (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
section candidate
no_agent (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
appsec (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
iast (18.626 s) : 18626000, 18626000
. : milestone, 18626000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (15.72 s) : 15720000, 15720000
. : milestone, 15720000,
tracing (15.237 s) : 15237000, 15237000
. : milestone, 15237000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a duplicate of what is already done in #9388
You only need to focus of the beforeFinish()
change. All the APIGW work (design, performance improvement, testing) is already done there.
What Does This Do
Implements APIGW with Context API
Utilizes context within
beforeFinish
to close APIGW span if necessaryRefers to #9388 for clean APIGW implementation details
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]