-
Notifications
You must be signed in to change notification settings - Fork 313
add support debugger/v2/input endpoint #9406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (341.756 µs) : 276, 408
. : milestone, 342,
basic (280.903 µs) : 274, 288
. : milestone, 281,
loop (8.962 ms) : 8956, 8967
. : milestone, 8962,
section candidate
noprobe (314.493 µs) : 288, 341
. : milestone, 314,
basic (274.082 µs) : 268, 280
. : milestone, 274,
loop (8.957 ms) : 8953, 8961
. : milestone, 8957,
|
🎯 Code Coverage 🔗 Commit SHA: 8b3d4ff | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048233
Total [baseline] (8.627 s) : 0, 8627010
Agent [candidate] (1.046 s) : 0, 1046362
Total [candidate] (8.621 s) : 0, 8620698
section iast
Agent [baseline] (1.18 s) : 0, 1179502
Total [baseline] (9.35 s) : 0, 9350103
Agent [candidate] (1.187 s) : 0, 1187222
Total [candidate] (9.359 s) : 0, 9359414
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (732.655 ms) : 0, 732655
BytebuddyAgent [candidate] (732.611 ms) : 0, 732611
GlobalTracer [baseline] (243.094 ms) : 0, 243094
GlobalTracer [candidate] (242.913 ms) : 0, 242913
AppSec [baseline] (30.182 ms) : 0, 30182
AppSec [candidate] (30.104 ms) : 0, 30104
Debugger [baseline] (6.102 ms) : 0, 6102
Debugger [candidate] (6.074 ms) : 0, 6074
Remote Config [baseline] (659.805 µs) : 0, 660
Remote Config [candidate] (671.737 µs) : 0, 672
Telemetry [baseline] (13.061 ms) : 0, 13061
Telemetry [candidate] (11.513 ms) : 0, 11513
section iast
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (851.439 ms) : 0, 851439
BytebuddyAgent [candidate] (857.696 ms) : 0, 857696
GlobalTracer [baseline] (233.784 ms) : 0, 233784
GlobalTracer [candidate] (235.841 ms) : 0, 235841
AppSec [baseline] (25.989 ms) : 0, 25989
AppSec [candidate] (27.711 ms) : 0, 27711
Debugger [baseline] (7.533 ms) : 0, 7533
Debugger [candidate] (5.73 ms) : 0, 5730
Remote Config [baseline] (596.581 µs) : 0, 597
Remote Config [candidate] (605.73 µs) : 0, 606
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (8.249 ms) : 0, 8249
IAST [baseline] (29.38 ms) : 0, 29380
IAST [candidate] (28.805 ms) : 0, 28805
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054850
Total [baseline] (10.773 s) : 0, 10772872
Agent [candidate] (1.052 s) : 0, 1052176
Total [candidate] (10.737 s) : 0, 10737184
section appsec
Agent [baseline] (1.231 s) : 0, 1230755
Total [baseline] (10.82 s) : 0, 10819904
Agent [candidate] (1.224 s) : 0, 1223918
Total [candidate] (10.852 s) : 0, 10852079
section iast
Agent [baseline] (1.191 s) : 0, 1190956
Total [baseline] (10.994 s) : 0, 10993933
Agent [candidate] (1.181 s) : 0, 1180782
Total [candidate] (10.883 s) : 0, 10883199
section profiling
Agent [baseline] (1.2 s) : 0, 1200245
Total [baseline] (10.957 s) : 0, 10956601
Agent [candidate] (1.215 s) : 0, 1215424
Total [candidate] (10.992 s) : 0, 10991512
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (736.863 ms) : 0, 736863
BytebuddyAgent [candidate] (734.834 ms) : 0, 734834
GlobalTracer [baseline] (244.263 ms) : 0, 244263
GlobalTracer [candidate] (244.428 ms) : 0, 244428
AppSec [baseline] (30.442 ms) : 0, 30442
AppSec [candidate] (30.302 ms) : 0, 30302
Debugger [baseline] (6.118 ms) : 0, 6118
Debugger [candidate] (6.131 ms) : 0, 6131
Remote Config [baseline] (679.938 µs) : 0, 680
Remote Config [candidate] (679.567 µs) : 0, 680
Telemetry [baseline] (13.753 ms) : 0, 13753
Telemetry [candidate] (13.118 ms) : 0, 13118
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (760.24 ms) : 0, 760240
BytebuddyAgent [candidate] (755.323 ms) : 0, 755323
GlobalTracer [baseline] (236.771 ms) : 0, 236771
GlobalTracer [candidate] (235.918 ms) : 0, 235918
IAST [baseline] (23.809 ms) : 0, 23809
IAST [candidate] (23.531 ms) : 0, 23531
AppSec [baseline] (169.302 ms) : 0, 169302
AppSec [candidate] (170.04 ms) : 0, 170040
Debugger [baseline] (6.595 ms) : 0, 6595
Debugger [candidate] (7.414 ms) : 0, 7414
Remote Config [baseline] (629.681 µs) : 0, 630
Remote Config [candidate] (641.626 µs) : 0, 642
Telemetry [baseline] (10.708 ms) : 0, 10708
Telemetry [candidate] (8.473 ms) : 0, 8473
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (859.245 ms) : 0, 859245
BytebuddyAgent [candidate] (852.148 ms) : 0, 852148
GlobalTracer [baseline] (234.833 ms) : 0, 234833
GlobalTracer [candidate] (233.691 ms) : 0, 233691
IAST [baseline] (29.009 ms) : 0, 29009
IAST [candidate] (31.877 ms) : 0, 31877
AppSec [baseline] (30.066 ms) : 0, 30066
AppSec [candidate] (25.017 ms) : 0, 25017
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (6.64 ms) : 0, 6640
Remote Config [baseline] (629.18 µs) : 0, 629
Remote Config [candidate] (597.752 µs) : 0, 598
Telemetry [baseline] (8.529 ms) : 0, 8529
Telemetry [candidate] (8.268 ms) : 0, 8268
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (763.642 ms) : 0, 763642
BytebuddyAgent [candidate] (774.442 ms) : 0, 774442
GlobalTracer [baseline] (223.238 ms) : 0, 223238
GlobalTracer [candidate] (224.988 ms) : 0, 224988
AppSec [baseline] (30.167 ms) : 0, 30167
AppSec [candidate] (30.68 ms) : 0, 30680
Debugger [baseline] (6.304 ms) : 0, 6304
Debugger [candidate] (6.384 ms) : 0, 6384
Remote Config [baseline] (734.973 µs) : 0, 735
Remote Config [candidate] (752.887 µs) : 0, 753
Telemetry [baseline] (15.669 ms) : 0, 15669
Telemetry [candidate] (16.587 ms) : 0, 16587
ProfilingAgent [baseline] (109.265 ms) : 0, 109265
ProfilingAgent [candidate] (109.556 ms) : 0, 109556
Profiling [baseline] (109.888 ms) : 0, 109888
Profiling [candidate] (110.219 ms) : 0, 110219
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (4.251 ms) : 4203, 4299
. : milestone, 4251,
iast (9.658 ms) : 9500, 9816
. : milestone, 9658,
iast_FULL (13.863 ms) : 13588, 14138
. : milestone, 13863,
iast_GLOBAL (10.407 ms) : 10220, 10594
. : milestone, 10407,
profiling (8.902 ms) : 8755, 9048
. : milestone, 8902,
tracing (7.64 ms) : 7533, 7747
. : milestone, 7640,
section candidate
no_agent (4.384 ms) : 4334, 4433
. : milestone, 4384,
iast (9.715 ms) : 9546, 9883
. : milestone, 9715,
iast_FULL (14.282 ms) : 13999, 14565
. : milestone, 14282,
iast_GLOBAL (10.49 ms) : 10303, 10676
. : milestone, 10490,
profiling (8.927 ms) : 8778, 9077
. : milestone, 8927,
tracing (7.505 ms) : 7396, 7614
. : milestone, 7505,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (37.807 ms) : 37500, 38113
. : milestone, 37807,
appsec (48.338 ms) : 47899, 48777
. : milestone, 48338,
code_origins (46.027 ms) : 45632, 46422
. : milestone, 46027,
iast (45.854 ms) : 45449, 46259
. : milestone, 45854,
profiling (49.846 ms) : 49362, 50330
. : milestone, 49846,
tracing (44.358 ms) : 43980, 44737
. : milestone, 44358,
section candidate
no_agent (37.245 ms) : 36947, 37542
. : milestone, 37245,
appsec (48.028 ms) : 47590, 48466
. : milestone, 48028,
code_origins (46.157 ms) : 45756, 46559
. : milestone, 46157,
iast (45.354 ms) : 44959, 45749
. : milestone, 45354,
profiling (49.112 ms) : 48672, 49553
. : milestone, 49112,
tracing (43.561 ms) : 43175, 43947
. : milestone, 43561,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (14.758 s) : 14758000, 14758000
. : milestone, 14758000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.424 s) : 18424000, 18424000
. : milestone, 18424000,
iast_GLOBAL (18.337 s) : 18337000, 18337000
. : milestone, 18337000,
profiling (15.992 s) : 15992000, 15992000
. : milestone, 15992000,
tracing (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
section candidate
no_agent (15.47 s) : 15470000, 15470000
. : milestone, 15470000,
appsec (14.751 s) : 14751000, 14751000
. : milestone, 14751000,
iast (18.783 s) : 18783000, 18783000
. : milestone, 18783000,
iast_GLOBAL (18.466 s) : 18466000, 18466000
. : milestone, 18466000,
profiling (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
tracing (15.311 s) : 15311000, 15311000
. : milestone, 15311000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~8b3d4ffc95, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.665 ms) : 3448, 3882
. : milestone, 3665,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.25 ms) : 2187, 2313
. : milestone, 2250,
profiling (2.04 ms) : 1989, 2090
. : milestone, 2040,
tracing (2.025 ms) : 1976, 2074
. : milestone, 2025,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.695 ms) : 3477, 3912
. : milestone, 3695,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.263 ms) : 2199, 2326
. : milestone, 2263,
profiling (2.081 ms) : 2028, 2133
. : milestone, 2081,
tracing (2.033 ms) : 1984, 2082
. : milestone, 2033,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add smoke tests in a next PR
What Does This Do
Add support for new endpoint debugger/v2/input at datadog agent.
the tracer would try to use the endpoints in this order:
Motivation
we are in a process of directing all snapshots captured into DEBUGGER track (currently they sent to LOGS).
So, in order to allow new tracers to direct messages to DEBUGGER track without require agent upgrade, we fallback to diagnostics endpoint (that already send probe status to the DEBUGGER track).
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-4340