-
Notifications
You must be signed in to change notification settings - Fork 313
Daniel.mohedano/logs backend logging #9411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
) * Make rum injector stream/writer more resilient to errors (cherry picked from commit a298c60) * fix tests (cherry picked from commit 62acf7c) * fix tests (cherry picked from commit 5a32d51) * Update dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/buffer/InjectingPipeOutputStream.java Co-authored-by: Stuart McCulloch <[email protected]> (cherry picked from commit 87d15fb) * apply suggestions (cherry picked from commit 21afeb2) --------- Co-authored-by: Stuart McCulloch <[email protected]>
#9342) * Make rum injector stream/writer more resilient to errors (cherry picked from commit 36246b4) * fix tests (cherry picked from commit 993bf57) * Improve RUM injection matching and avoid truncating responses (cherry picked from commit f46c8f1) * Use MH for setContentLengthLong since available from 3.1 (cherry picked from commit 13753c1) * Fix tomcat11 tests (cherry picked from commit 4fb4129) * Update dd-smoke-tests/rum/src/main/groovy/datadog/smoketest/rum/AbstractRumServerSmokeTest.groovy Co-authored-by: Bruce Bujon <[email protected]> (cherry picked from commit 4b44a38) * Update dd-smoke-tests/rum/src/main/groovy/datadog/smoketest/rum/AbstractRumServerSmokeTest.groovy Co-authored-by: Bruce Bujon <[email protected]> (cherry picked from commit d7e1fdf) * remove leftover (cherry picked from commit 22e5389) --------- Co-authored-by: Bruce Bujon <[email protected]>
Backport #9355 to release/v1.52.x
(cherry picked from commit ffa80b2)
🎯 Code Coverage 🔗 Commit SHA: 907cdfa | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056770
Total [baseline] (8.614 s) : 0, 8613607
Agent [candidate] (1.049 s) : 0, 1049384
Total [candidate] (8.626 s) : 0, 8625547
section iast
Agent [baseline] (1.182 s) : 0, 1182424
Total [baseline] (9.304 s) : 0, 9304493
Agent [candidate] (1.181 s) : 0, 1180506
Total [candidate] (9.364 s) : 0, 9364492
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (739.182 ms) : 0, 739182
BytebuddyAgent [candidate] (734.329 ms) : 0, 734329
GlobalTracer [baseline] (244.537 ms) : 0, 244537
GlobalTracer [candidate] (242.703 ms) : 0, 242703
AppSec [baseline] (30.482 ms) : 0, 30482
AppSec [candidate] (30.143 ms) : 0, 30143
Debugger [baseline] (6.163 ms) : 0, 6163
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (680.956 µs) : 0, 681
Remote Config [candidate] (681.527 µs) : 0, 682
Telemetry [baseline] (13.147 ms) : 0, 13147
Telemetry [candidate] (12.911 ms) : 0, 12911
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (853.685 ms) : 0, 853685
BytebuddyAgent [candidate] (852.537 ms) : 0, 852537
GlobalTracer [baseline] (233.646 ms) : 0, 233646
GlobalTracer [candidate] (233.672 ms) : 0, 233672
AppSec [baseline] (26.818 ms) : 0, 26818
AppSec [candidate] (26.395 ms) : 0, 26395
Debugger [baseline] (5.756 ms) : 0, 5756
Debugger [candidate] (6.794 ms) : 0, 6794
Remote Config [baseline] (608.814 µs) : 0, 609
Remote Config [candidate] (606.716 µs) : 0, 607
Telemetry [baseline] (8.365 ms) : 0, 8365
Telemetry [candidate] (8.14 ms) : 0, 8140
IAST [baseline] (31.086 ms) : 0, 31086
IAST [candidate] (29.897 ms) : 0, 29897
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047831
Total [baseline] (10.722 s) : 0, 10721901
Agent [candidate] (1.056 s) : 0, 1055891
Total [candidate] (10.795 s) : 0, 10794796
section appsec
Agent [baseline] (1.224 s) : 0, 1224047
Total [baseline] (10.794 s) : 0, 10793745
Agent [candidate] (1.225 s) : 0, 1225315
Total [candidate] (10.794 s) : 0, 10793958
section iast
Agent [baseline] (1.181 s) : 0, 1180637
Total [baseline] (11.025 s) : 0, 11024822
Agent [candidate] (1.186 s) : 0, 1186378
Total [candidate] (10.909 s) : 0, 10909153
section profiling
Agent [baseline] (1.2 s) : 0, 1199728
Total [baseline] (10.927 s) : 0, 10926871
Agent [candidate] (1.195 s) : 0, 1194790
Total [candidate] (10.922 s) : 0, 10922206
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (732.23 ms) : 0, 732230
BytebuddyAgent [candidate] (738.618 ms) : 0, 738618
GlobalTracer [baseline] (242.587 ms) : 0, 242587
GlobalTracer [candidate] (244.252 ms) : 0, 244252
AppSec [baseline] (30.0 ms) : 0, 30000
AppSec [candidate] (30.516 ms) : 0, 30516
Debugger [baseline] (6.063 ms) : 0, 6063
Debugger [candidate] (6.146 ms) : 0, 6146
Remote Config [baseline] (670.801 µs) : 0, 671
Remote Config [candidate] (687.186 µs) : 0, 687
Telemetry [baseline] (13.703 ms) : 0, 13703
Telemetry [candidate] (12.978 ms) : 0, 12978
section appsec
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (754.575 ms) : 0, 754575
BytebuddyAgent [candidate] (757.327 ms) : 0, 757327
GlobalTracer [baseline] (236.394 ms) : 0, 236394
GlobalTracer [candidate] (235.385 ms) : 0, 235385
AppSec [baseline] (171.021 ms) : 0, 171021
AppSec [candidate] (168.814 ms) : 0, 168814
Debugger [baseline] (5.76 ms) : 0, 5760
Debugger [candidate] (7.934 ms) : 0, 7934
Remote Config [baseline] (638.183 µs) : 0, 638
Remote Config [candidate] (639.488 µs) : 0, 639
Telemetry [baseline] (9.305 ms) : 0, 9305
Telemetry [candidate] (9.088 ms) : 0, 9088
IAST [baseline] (23.774 ms) : 0, 23774
IAST [candidate] (23.519 ms) : 0, 23519
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (851.402 ms) : 0, 851402
BytebuddyAgent [candidate] (857.158 ms) : 0, 857158
GlobalTracer [baseline] (233.566 ms) : 0, 233566
GlobalTracer [candidate] (233.176 ms) : 0, 233176
AppSec [baseline] (26.037 ms) : 0, 26037
AppSec [candidate] (26.461 ms) : 0, 26461
Debugger [baseline] (5.798 ms) : 0, 5798
Debugger [candidate] (7.601 ms) : 0, 7601
Remote Config [baseline] (614.666 µs) : 0, 615
Remote Config [candidate] (617.634 µs) : 0, 618
Telemetry [baseline] (8.413 ms) : 0, 8413
Telemetry [candidate] (8.203 ms) : 0, 8203
IAST [baseline] (32.249 ms) : 0, 32249
IAST [candidate] (30.55 ms) : 0, 30550
section profiling
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.407 ms) : 0, 1407
BytebuddyAgent [baseline] (763.566 ms) : 0, 763566
BytebuddyAgent [candidate] (760.497 ms) : 0, 760497
GlobalTracer [baseline] (222.727 ms) : 0, 222727
GlobalTracer [candidate] (221.957 ms) : 0, 221957
AppSec [baseline] (30.109 ms) : 0, 30109
AppSec [candidate] (30.038 ms) : 0, 30038
Debugger [baseline] (6.328 ms) : 0, 6328
Debugger [candidate] (6.381 ms) : 0, 6381
Remote Config [baseline] (693.038 µs) : 0, 693
Remote Config [candidate] (695.251 µs) : 0, 695
Telemetry [baseline] (15.793 ms) : 0, 15793
Telemetry [candidate] (15.423 ms) : 0, 15423
ProfilingAgent [baseline] (109.215 ms) : 0, 109215
ProfilingAgent [candidate] (108.753 ms) : 0, 108753
Profiling [baseline] (109.847 ms) : 0, 109847
Profiling [candidate] (109.424 ms) : 0, 109424
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section baseline
no_agent (38.173 ms) : 37871, 38475
. : milestone, 38173,
appsec (45.828 ms) : 45437, 46219
. : milestone, 45828,
code_origins (44.19 ms) : 43815, 44565
. : milestone, 44190,
iast (46.143 ms) : 45732, 46555
. : milestone, 46143,
profiling (45.171 ms) : 44777, 45566
. : milestone, 45171,
tracing (42.778 ms) : 42415, 43141
. : milestone, 42778,
section candidate
no_agent (37.256 ms) : 36955, 37556
. : milestone, 37256,
appsec (47.433 ms) : 47018, 47848
. : milestone, 47433,
code_origins (44.032 ms) : 43655, 44409
. : milestone, 44032,
iast (45.431 ms) : 45044, 45817
. : milestone, 45431,
profiling (47.149 ms) : 46700, 47599
. : milestone, 47149,
tracing (43.906 ms) : 43534, 44278
. : milestone, 43906,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section baseline
no_agent (4.484 ms) : 4431, 4537
. : milestone, 4484,
iast (9.643 ms) : 9484, 9802
. : milestone, 9643,
iast_FULL (14.538 ms) : 14240, 14835
. : milestone, 14538,
iast_GLOBAL (10.657 ms) : 10469, 10845
. : milestone, 10657,
profiling (8.912 ms) : 8774, 9050
. : milestone, 8912,
tracing (7.483 ms) : 7367, 7598
. : milestone, 7483,
section candidate
no_agent (4.48 ms) : 4418, 4542
. : milestone, 4480,
iast (9.452 ms) : 9297, 9608
. : milestone, 9452,
iast_FULL (14.351 ms) : 14064, 14639
. : milestone, 14351,
iast_GLOBAL (10.085 ms) : 9912, 10257
. : milestone, 10085,
profiling (9.467 ms) : 9321, 9612
. : milestone, 9467,
tracing (7.572 ms) : 7466, 7678
. : milestone, 7572,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.664 ms) : 3446, 3882
. : milestone, 3664,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.257 ms) : 2194, 2321
. : milestone, 2257,
profiling (2.041 ms) : 1991, 2092
. : milestone, 2041,
tracing (2.025 ms) : 1976, 2074
. : milestone, 2025,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.692 ms) : 3474, 3910
. : milestone, 3692,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.06 ms) : 2008, 2111
. : milestone, 2060,
tracing (2.023 ms) : 1974, 2072
. : milestone, 2023,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~907cdfadaa, baseline=1.53.0-SNAPSHOT~8799a82b0a
dateFormat X
axisFormat %s
section baseline
no_agent (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
appsec (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
iast (18.507 s) : 18507000, 18507000
. : milestone, 18507000,
iast_GLOBAL (17.94 s) : 17940000, 17940000
. : milestone, 17940000,
profiling (15.933 s) : 15933000, 15933000
. : milestone, 15933000,
tracing (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
section candidate
no_agent (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
appsec (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
iast (18.279 s) : 18279000, 18279000
. : milestone, 18279000,
iast_GLOBAL (17.92 s) : 17920000, 17920000
. : milestone, 17920000,
profiling (15.804 s) : 15804000, 15804000
. : milestone, 15804000,
tracing (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]