-
Notifications
You must be signed in to change notification settings - Fork 313
Refactor config into its own module #9426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: 50e5e23 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055307
Total [baseline] (10.775 s) : 0, 10775404
Agent [candidate] (1.06 s) : 0, 1060032
Total [candidate] (10.722 s) : 0, 10722242
section appsec
Agent [baseline] (1.23 s) : 0, 1230399
Total [baseline] (10.835 s) : 0, 10834820
Agent [candidate] (1.226 s) : 0, 1225580
Total [candidate] (10.807 s) : 0, 10807430
section iast
Agent [baseline] (1.194 s) : 0, 1193890
Total [baseline] (11.054 s) : 0, 11053948
Agent [candidate] (1.181 s) : 0, 1181459
Total [candidate] (10.999 s) : 0, 10999195
section profiling
Agent [baseline] (1.224 s) : 0, 1224321
Total [baseline] (11.06 s) : 0, 11060415
Agent [candidate] (1.2 s) : 0, 1199637
Total [candidate] (10.986 s) : 0, 10985538
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (738.988 ms) : 0, 738988
BytebuddyAgent [candidate] (741.192 ms) : 0, 741192
GlobalTracer [baseline] (243.682 ms) : 0, 243682
GlobalTracer [candidate] (245.224 ms) : 0, 245224
AppSec [baseline] (30.306 ms) : 0, 30306
AppSec [candidate] (30.467 ms) : 0, 30467
Debugger [baseline] (6.096 ms) : 0, 6096
Debugger [candidate] (6.059 ms) : 0, 6059
Remote Config [baseline] (689.459 µs) : 0, 689
Remote Config [candidate] (683.904 µs) : 0, 684
Telemetry [baseline] (12.97 ms) : 0, 12970
Telemetry [candidate] (13.763 ms) : 0, 13763
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (760.656 ms) : 0, 760656
BytebuddyAgent [candidate] (757.813 ms) : 0, 757813
GlobalTracer [baseline] (236.673 ms) : 0, 236673
GlobalTracer [candidate] (235.602 ms) : 0, 235602
IAST [baseline] (23.741 ms) : 0, 23741
IAST [candidate] (23.693 ms) : 0, 23693
AppSec [baseline] (170.92 ms) : 0, 170920
AppSec [candidate] (170.953 ms) : 0, 170953
Debugger [baseline] (5.857 ms) : 0, 5857
Debugger [candidate] (5.697 ms) : 0, 5697
Remote Config [baseline] (644.211 µs) : 0, 644
Remote Config [candidate] (633.524 µs) : 0, 634
Telemetry [baseline] (9.305 ms) : 0, 9305
Telemetry [candidate] (8.527 ms) : 0, 8527
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (861.884 ms) : 0, 861884
BytebuddyAgent [candidate] (852.209 ms) : 0, 852209
GlobalTracer [baseline] (235.515 ms) : 0, 235515
GlobalTracer [candidate] (234.455 ms) : 0, 234455
IAST [baseline] (29.115 ms) : 0, 29115
IAST [candidate] (27.949 ms) : 0, 27949
AppSec [baseline] (28.057 ms) : 0, 28057
AppSec [candidate] (29.452 ms) : 0, 29452
Debugger [baseline] (7.502 ms) : 0, 7502
Debugger [candidate] (5.742 ms) : 0, 5742
Remote Config [baseline] (619.102 µs) : 0, 619
Remote Config [candidate] (602.727 µs) : 0, 603
Telemetry [baseline] (8.499 ms) : 0, 8499
Telemetry [candidate] (8.37 ms) : 0, 8370
section profiling
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (779.896 ms) : 0, 779896
BytebuddyAgent [candidate] (764.42 ms) : 0, 764420
GlobalTracer [baseline] (227.048 ms) : 0, 227048
GlobalTracer [candidate] (222.546 ms) : 0, 222546
AppSec [baseline] (31.094 ms) : 0, 31094
AppSec [candidate] (30.065 ms) : 0, 30065
Debugger [baseline] (6.445 ms) : 0, 6445
Debugger [candidate] (6.263 ms) : 0, 6263
Remote Config [baseline] (756.578 µs) : 0, 757
Remote Config [candidate] (714.874 µs) : 0, 715
Telemetry [baseline] (16.034 ms) : 0, 16034
Telemetry [candidate] (16.451 ms) : 0, 16451
ProfilingAgent [baseline] (110.91 ms) : 0, 110910
ProfilingAgent [candidate] (107.803 ms) : 0, 107803
Profiling [baseline] (111.555 ms) : 0, 111555
Profiling [candidate] (108.475 ms) : 0, 108475
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047858
Total [baseline] (8.627 s) : 0, 8627492
Agent [candidate] (1.052 s) : 0, 1051922
Total [candidate] (8.641 s) : 0, 8641225
section iast
Agent [baseline] (1.18 s) : 0, 1179710
Total [baseline] (9.353 s) : 0, 9352878
Agent [candidate] (1.19 s) : 0, 1190057
Total [candidate] (9.387 s) : 0, 9387148
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (732.793 ms) : 0, 732793
BytebuddyAgent [candidate] (735.129 ms) : 0, 735129
GlobalTracer [baseline] (242.779 ms) : 0, 242779
GlobalTracer [candidate] (243.833 ms) : 0, 243833
AppSec [baseline] (30.198 ms) : 0, 30198
AppSec [candidate] (30.277 ms) : 0, 30277
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.086 ms) : 0, 6086
Remote Config [baseline] (686.159 µs) : 0, 686
Remote Config [candidate] (660.185 µs) : 0, 660
Telemetry [baseline] (12.919 ms) : 0, 12919
Telemetry [candidate] (13.561 ms) : 0, 13561
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (851.451 ms) : 0, 851451
BytebuddyAgent [candidate] (859.009 ms) : 0, 859009
GlobalTracer [baseline] (233.4 ms) : 0, 233400
GlobalTracer [candidate] (234.707 ms) : 0, 234707
IAST [baseline] (29.292 ms) : 0, 29292
IAST [candidate] (28.215 ms) : 0, 28215
AppSec [baseline] (28.359 ms) : 0, 28359
AppSec [candidate] (27.203 ms) : 0, 27203
Debugger [baseline] (5.757 ms) : 0, 5757
Debugger [candidate] (9.37 ms) : 0, 9370
Remote Config [baseline] (615.515 µs) : 0, 616
Remote Config [candidate] (628.289 µs) : 0, 628
Telemetry [baseline] (8.304 ms) : 0, 8304
Telemetry [candidate] (8.367 ms) : 0, 8367
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (4.437 ms) : 4387, 4487
. : milestone, 4437,
iast (9.141 ms) : 8991, 9290
. : milestone, 9141,
iast_FULL (14.295 ms) : 14010, 14581
. : milestone, 14295,
iast_GLOBAL (10.018 ms) : 9846, 10190
. : milestone, 10018,
profiling (8.706 ms) : 8562, 8849
. : milestone, 8706,
tracing (7.71 ms) : 7591, 7829
. : milestone, 7710,
section candidate
no_agent (4.636 ms) : 4583, 4689
. : milestone, 4636,
iast (10.022 ms) : 9848, 10195
. : milestone, 10022,
iast_FULL (13.551 ms) : 13283, 13820
. : milestone, 13551,
iast_GLOBAL (10.288 ms) : 10107, 10468
. : milestone, 10288,
profiling (8.779 ms) : 8636, 8921
. : milestone, 8779,
tracing (7.455 ms) : 7346, 7565
. : milestone, 7455,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (37.235 ms) : 36938, 37533
. : milestone, 37235,
appsec (50.241 ms) : 49787, 50696
. : milestone, 50241,
code_origins (45.541 ms) : 45125, 45957
. : milestone, 45541,
iast (45.912 ms) : 45517, 46308
. : milestone, 45912,
profiling (47.226 ms) : 46755, 47697
. : milestone, 47226,
tracing (45.233 ms) : 44864, 45603
. : milestone, 45233,
section candidate
no_agent (35.963 ms) : 35677, 36248
. : milestone, 35963,
appsec (47.475 ms) : 47037, 47913
. : milestone, 47475,
code_origins (45.936 ms) : 45526, 46347
. : milestone, 45936,
iast (46.26 ms) : 45853, 46667
. : milestone, 46260,
profiling (48.86 ms) : 48392, 49328
. : milestone, 48860,
tracing (44.782 ms) : 44387, 45178
. : milestone, 44782,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (15.598 s) : 15598000, 15598000
. : milestone, 15598000,
appsec (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
iast (18.173 s) : 18173000, 18173000
. : milestone, 18173000,
iast_GLOBAL (18.329 s) : 18329000, 18329000
. : milestone, 18329000,
profiling (15.364 s) : 15364000, 15364000
. : milestone, 15364000,
tracing (15.209 s) : 15209000, 15209000
. : milestone, 15209000,
section candidate
no_agent (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
appsec (14.621 s) : 14621000, 14621000
. : milestone, 14621000,
iast (18.028 s) : 18028000, 18028000
. : milestone, 18028000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
tracing (14.715 s) : 14715000, 14715000
. : milestone, 14715000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~50e5e2383b, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.697 ms) : 3479, 3915
. : milestone, 3697,
iast (2.211 ms) : 2148, 2274
. : milestone, 2211,
iast_GLOBAL (2.256 ms) : 2193, 2320
. : milestone, 2256,
profiling (2.055 ms) : 2004, 2106
. : milestone, 2055,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
section candidate
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (2.474 ms) : 2421, 2527
. : milestone, 2474,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.079 ms) : 2027, 2132
. : milestone, 2079,
tracing (2.033 ms) : 1984, 2082
. : milestone, 2033,
|
4120f07
to
2cd71e0
Compare
Using `utils` for now as it has `:dd-trace-api` as dependency so can't be considered as a `:component`.
2cd71e0
to
50e5e23
Compare
What Does This Do
This PR refactor the config related code into its own module.
Motivation
This would improve readability, maintenance and ownership.
Additional Notes
Using
:utils
as destination for now as the new config module still has:dd-trace-api
as dependency so can't be considered as a:component
.The
Config
andInstrumenterConfig
are not good candidate to the refactoring as they are too tightly coupled to many other products.The
DynamicConfig
could still be a good candidate (coupled with sampling internal api).I used Dependency Inversion for the OTel metrics collector. It’s needed for the
OtelEnvironmentConfigSource
but can’t be moved to the new config module as it’s heavily dependent on the telemetry code.We still need to :
:component:yaml
into this new module (only one class and one dependency, only used for stable config)Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]