-
Notifications
You must be signed in to change notification settings - Fork 312
Update Extended appsec request/response headers and request body collection #9428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: 1f7188b | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055254
Total [baseline] (10.768 s) : 0, 10767752
Agent [candidate] (1.048 s) : 0, 1047534
Total [candidate] (10.697 s) : 0, 10696894
section appsec
Agent [baseline] (1.225 s) : 0, 1225305
Total [baseline] (10.836 s) : 0, 10836017
Agent [candidate] (1.22 s) : 0, 1220255
Total [candidate] (10.801 s) : 0, 10801198
section iast
Agent [baseline] (1.185 s) : 0, 1185012
Total [baseline] (10.99 s) : 0, 10989756
Agent [candidate] (1.18 s) : 0, 1180296
Total [candidate] (10.957 s) : 0, 10957266
section profiling
Agent [baseline] (1.199 s) : 0, 1199333
Total [baseline] (10.947 s) : 0, 10947185
Agent [candidate] (1.197 s) : 0, 1196934
Total [candidate] (10.931 s) : 0, 10930915
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (738.17 ms) : 0, 738170
BytebuddyAgent [candidate] (732.478 ms) : 0, 732478
GlobalTracer [baseline] (243.823 ms) : 0, 243823
GlobalTracer [candidate] (242.548 ms) : 0, 242548
AppSec [baseline] (30.113 ms) : 0, 30113
AppSec [candidate] (30.096 ms) : 0, 30096
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.063 ms) : 0, 6063
Remote Config [baseline] (673.151 µs) : 0, 673
Remote Config [candidate] (669.014 µs) : 0, 669
Telemetry [baseline] (13.788 ms) : 0, 13788
Telemetry [candidate] (13.03 ms) : 0, 13030
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (757.315 ms) : 0, 757315
BytebuddyAgent [candidate] (753.825 ms) : 0, 753825
GlobalTracer [baseline] (235.635 ms) : 0, 235635
GlobalTracer [candidate] (234.696 ms) : 0, 234696
IAST [baseline] (23.565 ms) : 0, 23565
IAST [candidate] (23.576 ms) : 0, 23576
AppSec [baseline] (169.66 ms) : 0, 169660
AppSec [candidate] (169.424 ms) : 0, 169424
Debugger [baseline] (5.791 ms) : 0, 5791
Debugger [candidate] (6.438 ms) : 0, 6438
Remote Config [baseline] (656.399 µs) : 0, 656
Remote Config [candidate] (633.992 µs) : 0, 634
Telemetry [baseline] (9.998 ms) : 0, 9998
Telemetry [candidate] (9.174 ms) : 0, 9174
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (855.254 ms) : 0, 855254
BytebuddyAgent [candidate] (851.961 ms) : 0, 851961
GlobalTracer [baseline] (234.347 ms) : 0, 234347
GlobalTracer [candidate] (234.235 ms) : 0, 234235
IAST [baseline] (29.572 ms) : 0, 29572
IAST [candidate] (31.132 ms) : 0, 31132
AppSec [baseline] (26.89 ms) : 0, 26890
AppSec [candidate] (25.167 ms) : 0, 25167
Debugger [baseline] (7.443 ms) : 0, 7443
Debugger [candidate] (6.568 ms) : 0, 6568
Remote Config [baseline] (609.93 µs) : 0, 610
Remote Config [candidate] (613.48 µs) : 0, 613
Telemetry [baseline] (8.318 ms) : 0, 8318
Telemetry [candidate] (8.174 ms) : 0, 8174
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.414 ms) : 0, 1414
BytebuddyAgent [baseline] (763.53 ms) : 0, 763530
BytebuddyAgent [candidate] (762.953 ms) : 0, 762953
GlobalTracer [baseline] (222.993 ms) : 0, 222993
GlobalTracer [candidate] (222.118 ms) : 0, 222118
AppSec [baseline] (30.15 ms) : 0, 30150
AppSec [candidate] (30.89 ms) : 0, 30890
Debugger [baseline] (6.329 ms) : 0, 6329
Debugger [candidate] (6.305 ms) : 0, 6305
Remote Config [baseline] (702.365 µs) : 0, 702
Remote Config [candidate] (689.774 µs) : 0, 690
Telemetry [baseline] (15.796 ms) : 0, 15796
Telemetry [candidate] (15.476 ms) : 0, 15476
ProfilingAgent [baseline] (108.729 ms) : 0, 108729
ProfilingAgent [candidate] (107.602 ms) : 0, 107602
Profiling [baseline] (109.366 ms) : 0, 109366
Profiling [candidate] (108.241 ms) : 0, 108241
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046943
Total [baseline] (8.651 s) : 0, 8651271
Agent [candidate] (1.051 s) : 0, 1050550
Total [candidate] (8.655 s) : 0, 8655164
section iast
Agent [baseline] (1.18 s) : 0, 1180073
Total [baseline] (9.364 s) : 0, 9364173
Agent [candidate] (1.181 s) : 0, 1181103
Total [candidate] (9.366 s) : 0, 9366317
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (733.088 ms) : 0, 733088
BytebuddyAgent [candidate] (735.662 ms) : 0, 735662
GlobalTracer [baseline] (242.412 ms) : 0, 242412
GlobalTracer [candidate] (243.259 ms) : 0, 243259
AppSec [baseline] (30.054 ms) : 0, 30054
AppSec [candidate] (30.206 ms) : 0, 30206
Debugger [baseline] (6.042 ms) : 0, 6042
Debugger [candidate] (6.085 ms) : 0, 6085
Remote Config [baseline] (673.998 µs) : 0, 674
Remote Config [candidate] (674.864 µs) : 0, 675
Telemetry [baseline] (12.27 ms) : 0, 12270
Telemetry [candidate] (12.22 ms) : 0, 12220
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (851.33 ms) : 0, 851330
BytebuddyAgent [candidate] (852.109 ms) : 0, 852109
GlobalTracer [baseline] (233.039 ms) : 0, 233039
GlobalTracer [candidate] (233.54 ms) : 0, 233540
IAST [baseline] (30.61 ms) : 0, 30610
IAST [candidate] (29.626 ms) : 0, 29626
AppSec [baseline] (27.016 ms) : 0, 27016
AppSec [candidate] (27.86 ms) : 0, 27860
Debugger [baseline] (6.725 ms) : 0, 6725
Debugger [candidate] (5.775 ms) : 0, 5775
Remote Config [baseline] (619.36 µs) : 0, 619
Remote Config [candidate] (605.678 µs) : 0, 606
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (9.22 ms) : 0, 9220
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (4.262 ms) : 4215, 4309
. : milestone, 4262,
iast (9.152 ms) : 9002, 9303
. : milestone, 9152,
iast_FULL (13.909 ms) : 13633, 14185
. : milestone, 13909,
iast_GLOBAL (10.539 ms) : 10351, 10727
. : milestone, 10539,
profiling (8.8 ms) : 8661, 8938
. : milestone, 8800,
tracing (7.494 ms) : 7383, 7605
. : milestone, 7494,
section candidate
no_agent (4.355 ms) : 4307, 4403
. : milestone, 4355,
iast (9.298 ms) : 9146, 9451
. : milestone, 9298,
iast_FULL (14.081 ms) : 13801, 14360
. : milestone, 14081,
iast_GLOBAL (10.297 ms) : 10116, 10478
. : milestone, 10297,
profiling (8.625 ms) : 8475, 8776
. : milestone, 8625,
tracing (7.609 ms) : 7489, 7730
. : milestone, 7609,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (37.203 ms) : 36903, 37502
. : milestone, 37203,
appsec (47.228 ms) : 46818, 47638
. : milestone, 47228,
code_origins (46.032 ms) : 45630, 46435
. : milestone, 46032,
iast (44.691 ms) : 44318, 45063
. : milestone, 44691,
profiling (48.842 ms) : 48344, 49339
. : milestone, 48842,
tracing (43.865 ms) : 43491, 44239
. : milestone, 43865,
section candidate
no_agent (36.518 ms) : 36223, 36813
. : milestone, 36518,
appsec (47.832 ms) : 47410, 48253
. : milestone, 47832,
code_origins (45.931 ms) : 45540, 46321
. : milestone, 45931,
iast (43.631 ms) : 43244, 44018
. : milestone, 43631,
profiling (46.355 ms) : 45955, 46755
. : milestone, 46355,
tracing (42.21 ms) : 41860, 42560
. : milestone, 42210,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
appsec (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
iast (18.556 s) : 18556000, 18556000
. : milestone, 18556000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
profiling (15.347 s) : 15347000, 15347000
. : milestone, 15347000,
tracing (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
section candidate
no_agent (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
appsec (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
iast (18.337 s) : 18337000, 18337000
. : milestone, 18337000,
iast_GLOBAL (18.286 s) : 18286000, 18286000
. : milestone, 18286000,
profiling (15.39 s) : 15390000, 15390000
. : milestone, 15390000,
tracing (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~6110278cb5, baseline=1.53.0-SNAPSHOT~02a3250561
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.679 ms) : 3461, 3897
. : milestone, 3679,
iast (2.195 ms) : 2132, 2258
. : milestone, 2195,
iast_GLOBAL (2.252 ms) : 2189, 2315
. : milestone, 2252,
profiling (2.069 ms) : 2017, 2121
. : milestone, 2069,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.657 ms) : 3441, 3874
. : milestone, 3657,
iast (2.216 ms) : 2152, 2279
. : milestone, 2216,
iast_GLOBAL (2.252 ms) : 2189, 2316
. : milestone, 2252,
profiling (2.072 ms) : 2020, 2124
. : milestone, 2072,
tracing (2.029 ms) : 1980, 2078
. : milestone, 2029,
|
What Does This Do
_dd.appsec.rasp.request_body_size.exceeded
renamed to_dd.appsec.request_body_size.exceeded
Motivation
Update implementation to meet the new RFC requirements
Additional Notes
WIP
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58757