Skip to content

Rename request body sample rate config variable #9791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rename request body sample rate config variable #9791

wants to merge 2 commits into from

Conversation

@manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 17, 2025 •
edited
Loading

What Does This Do

Renames the sample rate config variable from api-security.downstream.request.analysis.sample_rate to api-security.downstream.request.body.analysis.sample_rate.

Motivation

Due to an issue in the RFC, both variable names were listed. Tracers should use api-security.downstream.request.body.analysis.sample_rate.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: bug Bug report and fix comp: asm waf Application Security Management (WAF) labels Oct 17, 2025
jandro996
jandro996 reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if any user is actually using the old env variable? I guess not, since it was released in the last version and probably isn’t in the public docs. Might be worth keeping both variables for now, just in case? I assume the answer is no, but just wanted to flag it in case you hadn’t considered it 🙂

@datadog-official
Copy link

datadog-official bot commented Oct 17, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 62.17% (+2.47%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 34aa1f7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/fix-api10-sampling-config
git_commit_date 1761831120 1761831281
git_commit_sha 3a5a7f8 34aa1f7
release_version 1.55.0-SNAPSHOT~3a5a7f86c9 1.55.0-SNAPSHOT~34aa1f74c1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1761832983 1761832983
ci_job_id 1206605975 1206605975
ci_pipeline_id 80740866 80740866
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ngt1xb0e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ngt1xb0e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1032049
Total [baseline] (10.781 s) : 0, 10781219
Agent [candidate] (1.032 s) : 0, 1032031
Total [candidate] (10.842 s) : 0, 10842484
section appsec
Agent [baseline] (1.222 s) : 0, 1221842
Total [baseline] (11.018 s) : 0, 11018345
Agent [candidate] (1.205 s) : 0, 1204508
Total [candidate] (10.943 s) : 0, 10943313
section iast
Agent [baseline] (1.16 s) : 0, 1159541
Total [baseline] (11.149 s) : 0, 11149246
Agent [candidate] (1.158 s) : 0, 1158436
Total [candidate] (11.163 s) : 0, 11162791
section profiling
Agent [baseline] (1.175 s) : 0, 1174641
Total [baseline] (10.964 s) : 0, 10963967
Agent [candidate] (1.172 s) : 0, 1172298
Total [candidate] (10.849 s) : 0, 10848724
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.032 s -
Agent appsec 1.222 s 189.793 ms (18.4%)
Agent iast 1.16 s 127.492 ms (12.4%)
Agent profiling 1.175 s 142.592 ms (13.8%)
Total tracing 10.781 s -
Total appsec 11.018 s 237.126 ms (2.2%)
Total iast 11.149 s 368.026 ms (3.4%)
Total profiling 10.964 s 182.747 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.032 s -
Agent appsec 1.205 s 172.477 ms (16.7%)
Agent iast 1.158 s 126.405 ms (12.2%)
Agent profiling 1.172 s 140.267 ms (13.6%)
Total tracing 10.842 s -
Total appsec 10.943 s 100.828 ms (0.9%)
Total iast 11.163 s 320.307 ms (3.0%)
Total profiling 10.849 s 6.24 ms (0.1%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (703.462 ms) : 0, 703462
BytebuddyAgent [candidate] (703.212 ms) : 0, 703212
GlobalTracer [baseline] (245.816 ms) : 0, 245816
GlobalTracer [candidate] (245.37 ms) : 0, 245370
AppSec [baseline] (32.21 ms) : 0, 32210
AppSec [candidate] (32.437 ms) : 0, 32437
Debugger [baseline] (6.392 ms) : 0, 6392
Debugger [candidate] (6.39 ms) : 0, 6390
Remote Config [baseline] (678.479 µs) : 0, 678
Remote Config [candidate] (674.922 µs) : 0, 675
Telemetry [baseline] (15.153 ms) : 0, 15153
Telemetry [candidate] (16.118 ms) : 0, 16118
Flare Poller [baseline] (5.556 ms) : 0, 5556
Flare Poller [candidate] (5.023 ms) : 0, 5023
section appsec
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (738.832 ms) : 0, 738832
BytebuddyAgent [candidate] (727.64 ms) : 0, 727640
GlobalTracer [baseline] (239.401 ms) : 0, 239401
GlobalTracer [candidate] (236.256 ms) : 0, 236256
AppSec [baseline] (176.111 ms) : 0, 176111
AppSec [candidate] (174.241 ms) : 0, 174241
Debugger [baseline] (5.97 ms) : 0, 5970
Debugger [candidate] (5.893 ms) : 0, 5893
Remote Config [baseline] (639.726 µs) : 0, 640
Remote Config [candidate] (622.981 µs) : 0, 623
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.354 ms) : 0, 8354
Flare Poller [baseline] (3.909 ms) : 0, 3909
Flare Poller [candidate] (3.854 ms) : 0, 3854
IAST [baseline] (25.524 ms) : 0, 25524
IAST [candidate] (25.019 ms) : 0, 25019
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (822.454 ms) : 0, 822454
BytebuddyAgent [candidate] (822.237 ms) : 0, 822237
GlobalTracer [baseline] (233.768 ms) : 0, 233768
GlobalTracer [candidate] (233.532 ms) : 0, 233532
AppSec [baseline] (28.628 ms) : 0, 28628
AppSec [candidate] (27.764 ms) : 0, 27764
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (602.159 µs) : 0, 602
Remote Config [candidate] (592.744 µs) : 0, 593
Telemetry [baseline] (8.416 ms) : 0, 8416
Telemetry [candidate] (8.42 ms) : 0, 8420
Flare Poller [baseline] (4.068 ms) : 0, 4068
Flare Poller [candidate] (4.155 ms) : 0, 4155
IAST [baseline] (32.617 ms) : 0, 32617
IAST [candidate] (32.889 ms) : 0, 32889
section profiling
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (727.597 ms) : 0, 727597
BytebuddyAgent [candidate] (725.662 ms) : 0, 725662
GlobalTracer [baseline] (220.491 ms) : 0, 220491
GlobalTracer [candidate] (220.535 ms) : 0, 220535
AppSec [baseline] (32.334 ms) : 0, 32334
AppSec [candidate] (32.199 ms) : 0, 32199
Debugger [baseline] (9.853 ms) : 0, 9853
Debugger [candidate] (12.959 ms) : 0, 12959
Remote Config [baseline] (2.222 ms) : 0, 2222
Remote Config [candidate] (1.532 ms) : 0, 1532
Telemetry [baseline] (11.44 ms) : 0, 11440
Telemetry [candidate] (8.996 ms) : 0, 8996
Flare Poller [baseline] (4.09 ms) : 0, 4090
Flare Poller [candidate] (4.083 ms) : 0, 4083
ProfilingAgent [baseline] (109.508 ms) : 0, 109508
ProfilingAgent [candidate] (109.36 ms) : 0, 109360
Profiling [baseline] (110.221 ms) : 0, 110221
Profiling [candidate] (109.978 ms) : 0, 109978
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029359
Total [baseline] (8.68 s) : 0, 8680062
Agent [candidate] (1.03 s) : 0, 1029932
Total [candidate] (8.652 s) : 0, 8652487
section iast
Agent [baseline] (1.171 s) : 0, 1170887
Total [baseline] (9.387 s) : 0, 9386610
Agent [candidate] (1.164 s) : 0, 1164098
Total [candidate] (9.368 s) : 0, 9367672
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.029 s -
Agent iast 1.171 s 141.528 ms (13.7%)
Total tracing 8.68 s -
Total iast 9.387 s 706.549 ms (8.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.03 s -
Agent iast 1.164 s 134.166 ms (13.0%)
Total tracing 8.652 s -
Total iast 9.368 s 715.185 ms (8.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (701.394 ms) : 0, 701394
BytebuddyAgent [candidate] (702.191 ms) : 0, 702191
GlobalTracer [baseline] (245.019 ms) : 0, 245019
GlobalTracer [candidate] (245.289 ms) : 0, 245289
AppSec [baseline] (32.237 ms) : 0, 32237
AppSec [candidate] (32.02 ms) : 0, 32020
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.355 ms) : 0, 6355
Remote Config [baseline] (693.262 µs) : 0, 693
Remote Config [candidate] (673.332 µs) : 0, 673
Telemetry [baseline] (16.01 ms) : 0, 16010
Telemetry [candidate] (14.398 ms) : 0, 14398
Flare Poller [baseline] (4.936 ms) : 0, 4936
Flare Poller [candidate] (6.369 ms) : 0, 6369
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (830.906 ms) : 0, 830906
BytebuddyAgent [candidate] (825.496 ms) : 0, 825496
GlobalTracer [baseline] (235.598 ms) : 0, 235598
GlobalTracer [candidate] (234.534 ms) : 0, 234534
AppSec [baseline] (28.389 ms) : 0, 28389
AppSec [candidate] (30.794 ms) : 0, 30794
Debugger [baseline] (6.158 ms) : 0, 6158
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (608.429 µs) : 0, 608
Remote Config [candidate] (597.801 µs) : 0, 598
Telemetry [baseline] (8.456 ms) : 0, 8456
Telemetry [candidate] (8.583 ms) : 0, 8583
Flare Poller [baseline] (4.203 ms) : 0, 4203
Flare Poller [candidate] (4.201 ms) : 0, 4201
IAST [baseline] (33.671 ms) : 0, 33671
IAST [candidate] (31.012 ms) : 0, 31012
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/fix-api10-sampling-config
git_commit_date 1761831120 1761831281
git_commit_sha 3a5a7f8 34aa1f7
release_version 1.55.0-SNAPSHOT~3a5a7f86c9 1.55.0-SNAPSHOT~34aa1f74c1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1761833556 1761833556
ci_job_id 1206605977 1206605977
ci_pipeline_id 80740866 80740866
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-bm74p9vj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-bm74p9vj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:no_agent:high_load better
[-1.348ms; -0.936ms] or [-7.070%; -4.912%]		 unstable
[-13.762op/s; +44.762op/s] or [-5.620%; +18.280%]		 17.923ms 260.375op/s 19.065ms 244.875op/s
scenario:load:petclinic:iast:high_load worse
[+756.567µs; +1154.240µs] or [+4.266%; +6.508%]		 unstable
[-40.895op/s; +14.083op/s] or [-15.546%; +5.353%]		 18.691ms 249.656op/s 17.736ms 263.062op/s
scenario:load:petclinic:appsec:high_load better
[-872.464µs; -429.295µs] or [-4.271%; -2.101%]		 unstable
[-17.657op/s; +32.595op/s] or [-7.725%; +14.261%]		 19.777ms 236.031op/s 20.428ms 228.562op/s
scenario:load:petclinic:tracing:high_load better
[-1.496ms; -1.089ms] or [-7.679%; -5.587%]		 unstable
[-9.817op/s; +43.567op/s] or [-4.097%; +18.181%]		 18.191ms 256.500op/s 19.484ms 239.625op/s
scenario:load:petclinic:code_origins:high_load worse
[+0.889ms; +1.276ms] or [+5.088%; +7.308%]		 unstable
[-43.791op/s; +12.854op/s] or [-16.393%; +4.812%]		 18.547ms 251.656op/s 17.464ms 267.125op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.194 ms) : 1182, 1205
.   : milestone, 1194,
iast (3.249 ms) : 3209, 3289
.   : milestone, 3249,
iast_FULL (5.613 ms) : 5558, 5669
.   : milestone, 5613,
iast_GLOBAL (3.609 ms) : 3547, 3671
.   : milestone, 3609,
profiling (1.897 ms) : 1880, 1913
.   : milestone, 1897,
tracing (1.788 ms) : 1773, 1803
.   : milestone, 1788,
section candidate
no_agent (1.223 ms) : 1210, 1235
.   : milestone, 1223,
iast (3.29 ms) : 3250, 3331
.   : milestone, 3290,
iast_FULL (5.699 ms) : 5643, 5755
.   : milestone, 5699,
iast_GLOBAL (3.564 ms) : 3511, 3617
.   : milestone, 3564,
profiling (1.897 ms) : 1881, 1913
.   : milestone, 1897,
tracing (1.792 ms) : 1778, 1807
.   : milestone, 1792,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.194 ms [1.182 ms, 1.205 ms] -
iast 3.249 ms [3.209 ms, 3.289 ms] 2.055 ms (172.2%)
iast_FULL 5.613 ms [5.558 ms, 5.669 ms] 4.42 ms (370.3%)
iast_GLOBAL 3.609 ms [3.547 ms, 3.671 ms] 2.415 ms (202.4%)
profiling 1.897 ms [1.88 ms, 1.913 ms] 703.101 µs (58.9%)
tracing 1.788 ms [1.773 ms, 1.803 ms] 594.598 µs (49.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.223 ms [1.21 ms, 1.235 ms] -
iast 3.29 ms [3.25 ms, 3.331 ms] 2.068 ms (169.1%)
iast_FULL 5.699 ms [5.643 ms, 5.755 ms] 4.476 ms (366.1%)
iast_GLOBAL 3.564 ms [3.511 ms, 3.617 ms] 2.341 ms (191.5%)
profiling 1.897 ms [1.881 ms, 1.913 ms] 674.491 µs (55.2%)
tracing 1.792 ms [1.778 ms, 1.807 ms] 569.693 µs (46.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.065 ms) : 18869, 19260
.   : milestone, 19065,
appsec (20.428 ms) : 20222, 20634
.   : milestone, 20428,
code_origins (17.464 ms) : 17292, 17636
.   : milestone, 17464,
iast (17.736 ms) : 17558, 17913
.   : milestone, 17736,
profiling (19.366 ms) : 19170, 19562
.   : milestone, 19366,
tracing (19.484 ms) : 19290, 19678
.   : milestone, 19484,
section candidate
no_agent (17.923 ms) : 17736, 18110
.   : milestone, 17923,
appsec (19.777 ms) : 19571, 19983
.   : milestone, 19777,
code_origins (18.547 ms) : 18359, 18734
.   : milestone, 18547,
iast (18.691 ms) : 18499, 18883
.   : milestone, 18691,
profiling (19.254 ms) : 19063, 19446
.   : milestone, 19254,
tracing (18.191 ms) : 18006, 18376
.   : milestone, 18191,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.065 ms [18.869 ms, 19.26 ms] -
appsec 20.428 ms [20.222 ms, 20.634 ms] 1.364 ms (7.2%)
code_origins 17.464 ms [17.292 ms, 17.636 ms] -1.601 ms (-8.4%)
iast 17.736 ms [17.558 ms, 17.913 ms] -1.329 ms (-7.0%)
profiling 19.366 ms [19.17 ms, 19.562 ms] 301.323 µs (1.6%)
tracing 19.484 ms [19.29 ms, 19.678 ms] 418.937 µs (2.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.923 ms [17.736 ms, 18.11 ms] -
appsec 19.777 ms [19.571 ms, 19.983 ms] 1.855 ms (10.3%)
code_origins 18.547 ms [18.359 ms, 18.734 ms] 623.931 µs (3.5%)
iast 18.691 ms [18.499 ms, 18.883 ms] 768.542 µs (4.3%)
profiling 19.254 ms [19.063 ms, 19.446 ms] 1.332 ms (7.4%)
tracing 18.191 ms [18.006 ms, 18.376 ms] 268.696 µs (1.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/fix-api10-sampling-config
git_commit_date 1761831120 1761831281
git_commit_sha 3a5a7f8 34aa1f7
release_version 1.55.0-SNAPSHOT~3a5a7f86c9 1.55.0-SNAPSHOT~34aa1f74c1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1761833274 1761833274
ci_job_id 1206605979 1206605979
ci_pipeline_id 80740866 80740866
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-gx6v51i5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-gx6v51i5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (3.698 ms) : 3480, 3915
.   : milestone, 3698,
iast (2.205 ms) : 2142, 2268
.   : milestone, 2205,
iast_GLOBAL (2.262 ms) : 2198, 2326
.   : milestone, 2262,
profiling (2.075 ms) : 2022, 2127
.   : milestone, 2075,
tracing (2.019 ms) : 1970, 2068
.   : milestone, 2019,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.632 ms) : 3420, 3844
.   : milestone, 3632,
iast (2.211 ms) : 2148, 2275
.   : milestone, 2211,
iast_GLOBAL (2.246 ms) : 2182, 2310
.   : milestone, 2246,
profiling (2.051 ms) : 1999, 2102
.   : milestone, 2051,
tracing (2.027 ms) : 1977, 2076
.   : milestone, 2027,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 3.698 ms [3.48 ms, 3.915 ms] 2.224 ms (150.9%)
iast 2.205 ms [2.142 ms, 2.268 ms] 730.882 µs (49.6%)
iast_GLOBAL 2.262 ms [2.198 ms, 2.326 ms] 788.196 µs (53.5%)
profiling 2.075 ms [2.022 ms, 2.127 ms] 600.655 µs (40.7%)
tracing 2.019 ms [1.97 ms, 2.068 ms] 545.112 µs (37.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 3.632 ms [3.42 ms, 3.844 ms] 2.159 ms (146.6%)
iast 2.211 ms [2.148 ms, 2.275 ms] 738.183 µs (50.1%)
iast_GLOBAL 2.246 ms [2.182 ms, 2.31 ms] 773.409 µs (52.5%)
profiling 2.051 ms [1.999 ms, 2.102 ms] 577.847 µs (39.2%)
tracing 2.027 ms [1.977 ms, 2.076 ms] 553.904 µs (37.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~34aa1f74c1, baseline=1.55.0-SNAPSHOT~3a5a7f86c9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
appsec (14.808 s) : 14808000, 14808000
.   : milestone, 14808000,
iast (18.783 s) : 18783000, 18783000
.   : milestone, 18783000,
iast_GLOBAL (18.393 s) : 18393000, 18393000
.   : milestone, 18393000,
profiling (15.454 s) : 15454000, 15454000
.   : milestone, 15454000,
tracing (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
section candidate
no_agent (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
appsec (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
iast (18.574 s) : 18574000, 18574000
.   : milestone, 18574000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
.   : milestone, 17882000,
profiling (15.317 s) : 15317000, 15317000
.   : milestone, 15317000,
tracing (15.23 s) : 15230000, 15230000
.   : milestone, 15230000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.073 s [15.073 s, 15.073 s] -
appsec 14.808 s [14.808 s, 14.808 s] -265.0 ms (-1.8%)
iast 18.783 s [18.783 s, 18.783 s] 3.71 s (24.6%)
iast_GLOBAL 18.393 s [18.393 s, 18.393 s] 3.32 s (22.0%)
profiling 15.454 s [15.454 s, 15.454 s] 381.0 ms (2.5%)
tracing 14.963 s [14.963 s, 14.963 s] -110.0 ms (-0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.963 s [14.963 s, 14.963 s] -
appsec 15.039 s [15.039 s, 15.039 s] 76.0 ms (0.5%)
iast 18.574 s [18.574 s, 18.574 s] 3.611 s (24.1%)
iast_GLOBAL 17.882 s [17.882 s, 17.882 s] 2.919 s (19.5%)
profiling 15.317 s [15.317 s, 15.317 s] 354.0 ms (2.4%)
tracing 15.23 s [15.23 s, 15.23 s] 267.0 ms (1.8%)

Base automatically changed from malvarez/waf-fix-ssrf-blocking-exception to master October 17, 2025 13:16
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner October 17, 2025 13:16
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch 2 times, most recently from 6acbb27 to 4a5648d Compare October 17, 2025 13:36
@manuel-alvarez-alvarez
Copy link
Member Author

Do we know if any user is actually using the old env variable? I guess not, since it was released in the last version and probably isn’t in the public docs. Might be worth keeping both variables for now, just in case? I assume the answer is no, but just wanted to flag it in case you hadn’t considered it 🙂

Yeah, I added an alias to keep both for a while, thanks!

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch 2 times, most recently from ec39cb6 to 4cc6b68 Compare October 21, 2025 07:52
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch from 4cc6b68 to 34aa1f7 Compare October 30, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF) type: bug Bug report and fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuel-alvarez-alvarez @jandro996