-
Couldn't load subscription status.
- Fork 315
Don't attach parent run context when data.jobs.openlineage not enabled #9827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't attach parent run context when data.jobs.openlineage not enabled #9827
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: e677d95 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027923
Total [baseline] (8.675 s) : 0, 8675397
Agent [candidate] (1.022 s) : 0, 1022061
Total [candidate] (8.672 s) : 0, 8672090
section iast
Agent [baseline] (1.151 s) : 0, 1150663
Total [baseline] (9.286 s) : 0, 9286416
Agent [candidate] (1.152 s) : 0, 1152117
Total [candidate] (9.263 s) : 0, 9263267
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (702.262 ms) : 0, 702262
BytebuddyAgent [candidate] (695.986 ms) : 0, 695986
GlobalTracer [baseline] (244.23 ms) : 0, 244230
GlobalTracer [candidate] (243.384 ms) : 0, 243384
AppSec [baseline] (32.384 ms) : 0, 32384
AppSec [candidate] (32.155 ms) : 0, 32155
Debugger [baseline] (6.401 ms) : 0, 6401
Debugger [candidate] (6.263 ms) : 0, 6263
Remote Config [baseline] (692.699 µs) : 0, 693
Remote Config [candidate] (675.674 µs) : 0, 676
Telemetry [baseline] (9.401 ms) : 0, 9401
Telemetry [candidate] (9.359 ms) : 0, 9359
Flare Poller [baseline] (9.662 ms) : 0, 9662
Flare Poller [candidate] (11.513 ms) : 0, 11513
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (814.572 ms) : 0, 814572
BytebuddyAgent [candidate] (815.855 ms) : 0, 815855
GlobalTracer [baseline] (231.411 ms) : 0, 231411
GlobalTracer [candidate] (231.714 ms) : 0, 231714
AppSec [baseline] (35.231 ms) : 0, 35231
AppSec [candidate] (35.245 ms) : 0, 35245
Debugger [baseline] (6.204 ms) : 0, 6204
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (611.923 µs) : 0, 612
Remote Config [candidate] (599.173 µs) : 0, 599
Telemetry [baseline] (8.819 ms) : 0, 8819
Telemetry [candidate] (8.657 ms) : 0, 8657
Flare Poller [baseline] (4.236 ms) : 0, 4236
Flare Poller [candidate] (4.303 ms) : 0, 4303
IAST [baseline] (26.713 ms) : 0, 26713
IAST [candidate] (26.662 ms) : 0, 26662
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021639
Total [baseline] (10.722 s) : 0, 10722367
Agent [candidate] (1.019 s) : 0, 1019044
Total [candidate] (10.658 s) : 0, 10658132
section appsec
Agent [baseline] (1.195 s) : 0, 1194503
Total [baseline] (10.74 s) : 0, 10740137
Agent [candidate] (1.196 s) : 0, 1196158
Total [candidate] (10.786 s) : 0, 10785725
section iast
Agent [baseline] (1.152 s) : 0, 1152262
Total [baseline] (11.052 s) : 0, 11051718
Agent [candidate] (1.15 s) : 0, 1150497
Total [candidate] (11.101 s) : 0, 11101206
section profiling
Agent [baseline] (1.186 s) : 0, 1186363
Total [baseline] (10.91 s) : 0, 10909890
Agent [candidate] (1.164 s) : 0, 1164345
Total [candidate] (10.767 s) : 0, 10767273
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (694.826 ms) : 0, 694826
BytebuddyAgent [candidate] (693.438 ms) : 0, 693438
GlobalTracer [baseline] (244.411 ms) : 0, 244411
GlobalTracer [candidate] (243.119 ms) : 0, 243119
AppSec [baseline] (32.372 ms) : 0, 32372
AppSec [candidate] (32.333 ms) : 0, 32333
Debugger [baseline] (6.367 ms) : 0, 6367
Debugger [candidate] (6.334 ms) : 0, 6334
Remote Config [baseline] (692.155 µs) : 0, 692
Remote Config [candidate] (673.226 µs) : 0, 673
Telemetry [baseline] (9.309 ms) : 0, 9309
Telemetry [candidate] (9.245 ms) : 0, 9245
Flare Poller [baseline] (10.953 ms) : 0, 10953
Flare Poller [candidate] (11.199 ms) : 0, 11199
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (718.253 ms) : 0, 718253
BytebuddyAgent [candidate] (719.608 ms) : 0, 719608
GlobalTracer [baseline] (234.594 ms) : 0, 234594
GlobalTracer [candidate] (235.353 ms) : 0, 235353
AppSec [baseline] (174.671 ms) : 0, 174671
AppSec [candidate] (174.608 ms) : 0, 174608
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (6.011 ms) : 0, 6011
Remote Config [baseline] (624.03 µs) : 0, 624
Remote Config [candidate] (620.962 µs) : 0, 621
Telemetry [baseline] (8.544 ms) : 0, 8544
Telemetry [candidate] (8.509 ms) : 0, 8509
Flare Poller [baseline] (4.002 ms) : 0, 4002
Flare Poller [candidate] (3.892 ms) : 0, 3892
IAST [baseline] (25.002 ms) : 0, 25002
IAST [candidate] (24.91 ms) : 0, 24910
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (815.919 ms) : 0, 815919
BytebuddyAgent [candidate] (814.061 ms) : 0, 814061
GlobalTracer [baseline] (231.618 ms) : 0, 231618
GlobalTracer [candidate] (231.764 ms) : 0, 231764
AppSec [baseline] (35.301 ms) : 0, 35301
AppSec [candidate] (35.379 ms) : 0, 35379
Debugger [baseline] (6.15 ms) : 0, 6150
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (598.628 µs) : 0, 599
Remote Config [candidate] (613.033 µs) : 0, 613
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.735 ms) : 0, 8735
Flare Poller [baseline] (4.298 ms) : 0, 4298
Flare Poller [candidate] (4.214 ms) : 0, 4214
IAST [baseline] (26.674 ms) : 0, 26674
IAST [candidate] (26.612 ms) : 0, 26612
section profiling
ProfilingAgent [baseline] (112.174 ms) : 0, 112174
ProfilingAgent [candidate] (109.446 ms) : 0, 109446
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (733.971 ms) : 0, 733971
BytebuddyAgent [candidate] (720.348 ms) : 0, 720348
GlobalTracer [baseline] (222.624 ms) : 0, 222624
GlobalTracer [candidate] (219.386 ms) : 0, 219386
AppSec [baseline] (33.003 ms) : 0, 33003
AppSec [candidate] (32.295 ms) : 0, 32295
Debugger [baseline] (8.487 ms) : 0, 8487
Debugger [candidate] (6.699 ms) : 0, 6699
Remote Config [baseline] (722.476 µs) : 0, 722
Remote Config [candidate] (684.487 µs) : 0, 684
Telemetry [baseline] (13.049 ms) : 0, 13049
Telemetry [candidate] (15.94 ms) : 0, 15940
Flare Poller [baseline] (5.842 ms) : 0, 5842
Flare Poller [candidate] (4.214 ms) : 0, 4214
Profiling [baseline] (112.806 ms) : 0, 112806
Profiling [candidate] (110.077 ms) : 0, 110077
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section baseline
no_agent (36.813 ms) : 36521, 37106
. : milestone, 36813,
appsec (47.167 ms) : 46751, 47584
. : milestone, 47167,
code_origins (43.623 ms) : 43241, 44004
. : milestone, 43623,
iast (46.134 ms) : 45730, 46539
. : milestone, 46134,
profiling (49.913 ms) : 49446, 50379
. : milestone, 49913,
tracing (44.427 ms) : 44047, 44806
. : milestone, 44427,
section candidate
no_agent (36.852 ms) : 36553, 37151
. : milestone, 36852,
appsec (46.893 ms) : 46468, 47319
. : milestone, 46893,
code_origins (42.367 ms) : 42014, 42720
. : milestone, 42367,
iast (44.284 ms) : 43898, 44670
. : milestone, 44284,
profiling (47.807 ms) : 47395, 48219
. : milestone, 47807,
tracing (45.924 ms) : 45535, 46312
. : milestone, 45924,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section baseline
no_agent (4.283 ms) : 4228, 4338
. : milestone, 4283,
iast (9.51 ms) : 9350, 9670
. : milestone, 9510,
iast_FULL (13.889 ms) : 13610, 14168
. : milestone, 13889,
iast_GLOBAL (10.694 ms) : 10502, 10886
. : milestone, 10694,
profiling (8.778 ms) : 8626, 8929
. : milestone, 8778,
tracing (7.539 ms) : 7431, 7647
. : milestone, 7539,
section candidate
no_agent (4.296 ms) : 4245, 4347
. : milestone, 4296,
iast (9.63 ms) : 9467, 9793
. : milestone, 9630,
iast_FULL (13.545 ms) : 13280, 13810
. : milestone, 13545,
iast_GLOBAL (10.873 ms) : 10678, 11068
. : milestone, 10873,
profiling (8.996 ms) : 8855, 9138
. : milestone, 8996,
tracing (7.844 ms) : 7731, 7957
. : milestone, 7844,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section baseline
no_agent (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
appsec (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
iast (18.528 s) : 18528000, 18528000
. : milestone, 18528000,
iast_GLOBAL (18.273 s) : 18273000, 18273000
. : milestone, 18273000,
profiling (15.774 s) : 15774000, 15774000
. : milestone, 15774000,
tracing (15.141 s) : 15141000, 15141000
. : milestone, 15141000,
section candidate
no_agent (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
appsec (14.756 s) : 14756000, 14756000
. : milestone, 14756000,
iast (18.448 s) : 18448000, 18448000
. : milestone, 18448000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
. : milestone, 17970000,
profiling (15.729 s) : 15729000, 15729000
. : milestone, 15729000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e677d95556, baseline=1.55.0-SNAPSHOT~6837f840cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.743 ms) : 3523, 3963
. : milestone, 3743,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.237 ms) : 2173, 2300
. : milestone, 2237,
profiling (2.066 ms) : 2014, 2119
. : milestone, 2066,
tracing (2.017 ms) : 1967, 2066
. : milestone, 2017,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.64 ms) : 3427, 3853
. : milestone, 3640,
iast (2.204 ms) : 2140, 2268
. : milestone, 2204,
iast_GLOBAL (2.262 ms) : 2197, 2326
. : milestone, 2262,
profiling (2.068 ms) : 2015, 2120
. : milestone, 2068,
tracing (2.027 ms) : 1977, 2077
. : milestone, 2027,
|
|
|
||
| def "should create empty OpenLineageParentContext if data jobs openlineage not enabled" () { | ||
| given: | ||
| injectSysConfig("data.jobs.openlineage.enabled", "falsebrn") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ question: Is this a typo?
What Does This Do
Assure
OpenlineageParentContextis not attached ifdata.jobs.openlineage.enablednot enabled.Currently, this is happening within
initApplicationSpanIfNotInitializedmethod.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]