-
Couldn't load subscription status.
- Fork 315
Migrating Additional tests in ConfigTest that Utilize Fake Env Vars
#9860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 59a0d7c | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1036526
Total [baseline] (8.68 s) : 0, 8680060
Agent [candidate] (1.032 s) : 0, 1032438
Total [candidate] (8.71 s) : 0, 8710196
section iast
Agent [baseline] (1.171 s) : 0, 1171145
Total [baseline] (9.398 s) : 0, 9397867
Agent [candidate] (1.162 s) : 0, 1162054
Total [candidate] (9.311 s) : 0, 9311093
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (706.794 ms) : 0, 706794
BytebuddyAgent [candidate] (705.049 ms) : 0, 705049
GlobalTracer [baseline] (246.383 ms) : 0, 246383
GlobalTracer [candidate] (244.671 ms) : 0, 244671
AppSec [baseline] (32.893 ms) : 0, 32893
AppSec [candidate] (32.174 ms) : 0, 32174
Debugger [baseline] (6.519 ms) : 0, 6519
Debugger [candidate] (6.312 ms) : 0, 6312
Remote Config [baseline] (696.56 µs) : 0, 697
Remote Config [candidate] (680.292 µs) : 0, 680
Telemetry [baseline] (14.605 ms) : 0, 14605
Telemetry [candidate] (13.652 ms) : 0, 13652
Flare Poller [baseline] (5.801 ms) : 0, 5801
Flare Poller [candidate] (7.18 ms) : 0, 7180
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (830.991 ms) : 0, 830991
BytebuddyAgent [candidate] (824.831 ms) : 0, 824831
GlobalTracer [baseline] (235.48 ms) : 0, 235480
GlobalTracer [candidate] (234.031 ms) : 0, 234031
AppSec [baseline] (30.794 ms) : 0, 30794
AppSec [candidate] (29.718 ms) : 0, 29718
Debugger [baseline] (6.16 ms) : 0, 6160
Debugger [candidate] (6.111 ms) : 0, 6111
Remote Config [baseline] (608.737 µs) : 0, 609
Remote Config [candidate] (612.373 µs) : 0, 612
Telemetry [baseline] (8.567 ms) : 0, 8567
Telemetry [candidate] (8.43 ms) : 0, 8430
Flare Poller [baseline] (4.226 ms) : 0, 4226
Flare Poller [candidate] (4.151 ms) : 0, 4151
IAST [baseline] (31.352 ms) : 0, 31352
IAST [candidate] (31.456 ms) : 0, 31456
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1028307
Total [baseline] (10.832 s) : 0, 10831912
Agent [candidate] (1.03 s) : 0, 1030006
Total [candidate] (10.828 s) : 0, 10827610
section appsec
Agent [baseline] (1.209 s) : 0, 1209343
Total [baseline] (10.946 s) : 0, 10945873
Agent [candidate] (1.211 s) : 0, 1210989
Total [candidate] (10.953 s) : 0, 10952722
section iast
Agent [baseline] (1.171 s) : 0, 1170945
Total [baseline] (11.202 s) : 0, 11202398
Agent [candidate] (1.164 s) : 0, 1163585
Total [candidate] (11.157 s) : 0, 11156663
section profiling
Agent [baseline] (1.172 s) : 0, 1171536
Total [baseline] (10.816 s) : 0, 10815993
Agent [candidate] (1.174 s) : 0, 1173666
Total [candidate] (10.881 s) : 0, 10880754
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (701.061 ms) : 0, 701061
BytebuddyAgent [candidate] (702.445 ms) : 0, 702445
GlobalTracer [baseline] (244.613 ms) : 0, 244613
GlobalTracer [candidate] (244.806 ms) : 0, 244806
AppSec [baseline] (32.115 ms) : 0, 32115
AppSec [candidate] (32.117 ms) : 0, 32117
Debugger [baseline] (6.377 ms) : 0, 6377
Debugger [candidate] (6.341 ms) : 0, 6341
Remote Config [baseline] (699.101 µs) : 0, 699
Remote Config [candidate] (687.713 µs) : 0, 688
Telemetry [baseline] (15.886 ms) : 0, 15886
Telemetry [candidate] (14.36 ms) : 0, 14360
Flare Poller [baseline] (4.948 ms) : 0, 4948
Flare Poller [candidate] (6.533 ms) : 0, 6533
section appsec
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (729.701 ms) : 0, 729701
BytebuddyAgent [candidate] (731.722 ms) : 0, 731722
GlobalTracer [baseline] (237.135 ms) : 0, 237135
GlobalTracer [candidate] (237.643 ms) : 0, 237643
AppSec [baseline] (175.465 ms) : 0, 175465
AppSec [candidate] (174.636 ms) : 0, 174636
Debugger [baseline] (6.006 ms) : 0, 6006
Debugger [candidate] (5.928 ms) : 0, 5928
Remote Config [baseline] (631.985 µs) : 0, 632
Remote Config [candidate] (633.172 µs) : 0, 633
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.528 ms) : 0, 8528
Flare Poller [baseline] (3.916 ms) : 0, 3916
Flare Poller [candidate] (3.922 ms) : 0, 3922
IAST [baseline] (25.235 ms) : 0, 25235
IAST [candidate] (25.201 ms) : 0, 25201
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (831.776 ms) : 0, 831776
BytebuddyAgent [candidate] (825.72 ms) : 0, 825720
GlobalTracer [baseline] (235.441 ms) : 0, 235441
GlobalTracer [candidate] (234.125 ms) : 0, 234125
AppSec [baseline] (30.598 ms) : 0, 30598
AppSec [candidate] (30.614 ms) : 0, 30614
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (6.147 ms) : 0, 6147
Remote Config [baseline] (601.672 µs) : 0, 602
Remote Config [candidate] (664.46 µs) : 0, 664
Telemetry [baseline] (8.439 ms) : 0, 8439
Telemetry [candidate] (8.48 ms) : 0, 8480
Flare Poller [baseline] (4.102 ms) : 0, 4102
Flare Poller [candidate] (4.135 ms) : 0, 4135
IAST [baseline] (30.866 ms) : 0, 30866
IAST [candidate] (30.829 ms) : 0, 30829
section profiling
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (724.891 ms) : 0, 724891
BytebuddyAgent [candidate] (726.431 ms) : 0, 726431
GlobalTracer [baseline] (220.115 ms) : 0, 220115
GlobalTracer [candidate] (220.353 ms) : 0, 220353
AppSec [baseline] (32.378 ms) : 0, 32378
AppSec [candidate] (32.188 ms) : 0, 32188
Debugger [baseline] (12.489 ms) : 0, 12489
Debugger [candidate] (10.72 ms) : 0, 10720
Remote Config [baseline] (1.496 ms) : 0, 1496
Remote Config [candidate] (2.229 ms) : 0, 2229
Telemetry [baseline] (9.826 ms) : 0, 9826
Telemetry [candidate] (10.693 ms) : 0, 10693
Flare Poller [baseline] (4.076 ms) : 0, 4076
Flare Poller [candidate] (4.123 ms) : 0, 4123
ProfilingAgent [baseline] (109.514 ms) : 0, 109514
ProfilingAgent [candidate] (110.047 ms) : 0, 110047
Profiling [baseline] (110.151 ms) : 0, 110151
Profiling [candidate] (110.723 ms) : 0, 110723
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section baseline
no_agent (37.832 ms) : 37522, 38141
. : milestone, 37832,
appsec (48.028 ms) : 47609, 48447
. : milestone, 48028,
code_origins (43.565 ms) : 43178, 43952
. : milestone, 43565,
iast (43.558 ms) : 43175, 43942
. : milestone, 43558,
profiling (49.609 ms) : 49169, 50049
. : milestone, 49609,
tracing (46.192 ms) : 45795, 46590
. : milestone, 46192,
section candidate
no_agent (37.707 ms) : 37406, 38008
. : milestone, 37707,
appsec (47.626 ms) : 47201, 48052
. : milestone, 47626,
code_origins (43.62 ms) : 43247, 43992
. : milestone, 43620,
iast (45.703 ms) : 45308, 46098
. : milestone, 45703,
profiling (47.671 ms) : 47193, 48148
. : milestone, 47671,
tracing (43.862 ms) : 43486, 44239
. : milestone, 43862,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section baseline
no_agent (4.431 ms) : 4380, 4482
. : milestone, 4431,
iast (9.766 ms) : 9605, 9928
. : milestone, 9766,
iast_FULL (14.268 ms) : 13981, 14555
. : milestone, 14268,
iast_GLOBAL (10.217 ms) : 10032, 10401
. : milestone, 10217,
profiling (8.892 ms) : 8743, 9041
. : milestone, 8892,
tracing (8.026 ms) : 7892, 8161
. : milestone, 8026,
section candidate
no_agent (4.391 ms) : 4342, 4440
. : milestone, 4391,
iast (10.169 ms) : 9997, 10340
. : milestone, 10169,
iast_FULL (14.222 ms) : 13940, 14503
. : milestone, 14222,
iast_GLOBAL (11.094 ms) : 10893, 11294
. : milestone, 11094,
profiling (9.76 ms) : 9598, 9923
. : milestone, 9760,
tracing (7.881 ms) : 7768, 7993
. : milestone, 7881,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.681 ms) : 3463, 3898
. : milestone, 3681,
iast (2.206 ms) : 2143, 2269
. : milestone, 2206,
iast_GLOBAL (2.239 ms) : 2175, 2303
. : milestone, 2239,
profiling (2.071 ms) : 2019, 2124
. : milestone, 2071,
tracing (2.022 ms) : 1973, 2072
. : milestone, 2022,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.639 ms) : 3427, 3851
. : milestone, 3639,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.245 ms) : 2181, 2309
. : milestone, 2245,
profiling (2.461 ms) : 2305, 2617
. : milestone, 2461,
tracing (2.013 ms) : 1964, 2062
. : milestone, 2013,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~59a0d7cc93, baseline=1.55.0-SNAPSHOT~fb9d0a1c57
dateFormat X
axisFormat %s
section baseline
no_agent (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (18.791 s) : 18791000, 18791000
. : milestone, 18791000,
iast_GLOBAL (18.248 s) : 18248000, 18248000
. : milestone, 18248000,
profiling (16.03 s) : 16030000, 16030000
. : milestone, 16030000,
tracing (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (14.635 s) : 14635000, 14635000
. : milestone, 14635000,
iast (18.632 s) : 18632000, 18632000
. : milestone, 18632000,
iast_GLOBAL (18.152 s) : 18152000, 18152000
. : milestone, 18152000,
profiling (15.165 s) : 15165000, 15165000
. : milestone, 15165000,
tracing (15.259 s) : 15259000, 15259000
. : milestone, 15259000,
|
|
It feels that we might benefit from a |
What Does This Do
Followup to #9857 for tests that were not properly migrated.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]